Grab bag of more stuff from the backlog #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
changed the title
Yawning
force-pushed
the
yawning/feature/more-backlog
branch
8 times, most recently
from
f99d39f to
d43fd25
Compare
kostko
reviewed
Jun 11, 2020
| @@ -11,6 +11,8 @@ import ( | |||
| var envRuntimePath = os.Getenv("OASIS_TEST_RUNTIME_HOST_RUNTIME_PATH") | |||
|
|
|||
| func TestProvisionerSandbox(t *testing.T) { | |||
| const bwrapPath = "/usr/bin/bwrap" // Sensible systems only. | |||
There was a problem hiding this comment.
I assume the same fix is required in go/runtime/host/sgx/sgx_test.go (currently not tested in CI).
Codecov Report
@@ Coverage Diff @@
## master #3004 +/- ##
==========================================
- Coverage 68.62% 68.54% -0.09%
==========================================
Files 365 365
Lines 35669 35679 +10
==========================================
- Hits 24477 24455 -22
- Misses 8062 8092 +30
- Partials 3130 3132 +2
Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/feature/more-backlog
branch
from
d43fd25 to
7f63a02
Compare
kostko
approved these changes
Jun 11, 2020
This adds a new config option `--worker.runtime.sandbox_binary` that allows overriding the path to the sandbox support binary (ie: bwrap).
Yawning
force-pushed
the
yawning/feature/more-backlog
branch
from
7f63a02 to
48590f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
whichto figure out where bwrap is I am opting against that as unwise. If people are so inclined as to install bwrap by hand, they can set the config option themselves.Fixes #1599
Fixes #2469