Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bwrap location should not be hardcoded #1599

Closed
matevz opened this issue Apr 12, 2019 · 0 comments · Fixed by #3004
Closed

bwrap location should not be hardcoded #1599

matevz opened this issue Apr 12, 2019 · 0 comments · Fixed by #3004
Labels
s:good first issue Status: good for newcomers

Comments

@matevz
Copy link
Member

matevz commented Apr 12, 2019

Details

We use bwrap for running the ekiden worker in the restricted environment. Currently the location is hardcoded to /usr/bin/bwrap. If you install bwrap manually, then it's in /usr/local/bin/bwrap or even some third location. Make this path configurable.

Acceptance Criteria

  • workerBubblewrapBinary should be read from the config file. If not passed, it could be determined by which bwrap command.
@matevz matevz added the s:good first issue Status: good for newcomers label Apr 12, 2019
@Yawning Yawning mentioned this issue Jun 11, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s:good first issue Status: good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Grab bag of more stuff from the backlog oasisprotocol/oasis-core
1 participant
@matevz