[BACKPORT] Batch of backports to 20.5.x #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the IAS proxy could incorrectly panic during shutdown when the context was cancelled.
Common keymanager initalization code is extracted into the `keymanager-lib` crate. This enables for the actual key manager implementation to only provide a set of key manager policy signers. Aditionally the `keymanager-runtime` crate is removed and replaced with a test `simple-keymanager` runtime that is used in E2E tests.
Previously each endpoint required its own gRPC service. But since all EnclaveRPC requests already include an "endpoint" field, it is better to use that for routing requests. This commit adds a new enclaverpc.Endpoint interface that is used as an endpoint descriptor. All endpoints must be registered in advance (e.g., during init). It also changes the key manager EnclaveRPC support to use the new API. Since it changes the gRPC service name this BREAKS the committee gRPC protocol.
Previously we only tested the runtime transport for the key manager so this adds a test that also tests the gRPC transport.
There is a race condition where the committee client has been updated with new connections, but the policy has not yet been as the client is not yet frozen. This could previously lead to a panic in GetConnection but now correctly returns nil.
The condition may be transient if connection is in progress.
kostko
force-pushed
the
kostko/stable/20.5.x/backport-batch
branch
from
b8a1687 to
75b2bfa
Compare
Codecov Report
@@ Coverage Diff @@
## stable/20.5.x #2846 +/- ##
=================================================
+ Coverage 67.25% 68.30% +1.04%
=================================================
Files 343 342 -1
Lines 32987 33094 +107
=================================================
+ Hits 22187 22606 +419
+ Misses 8108 7758 -350
- Partials 2692 2730 +38
Continue to review full report at Codecov.
|
ptrus
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following:
GetEventsto backends #2841