Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetEvents to backends #2841

Merged
merged 9 commits into from
Apr 15, 2020
Merged

Add GetEvents to backends #2841

merged 9 commits into from
Apr 15, 2020

Conversation

abukosek
Copy link
Contributor

Fixes #2778.

@abukosek abukosek force-pushed the andrej/feature/query-events branch 2 times, most recently from dd4082d to f4c7915 Compare April 14, 2020 12:38
@abukosek abukosek force-pushed the andrej/feature/query-events branch from f4c7915 to be37971 Compare April 14, 2020 12:38
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the txsource query workload (see go/oasis-node/cmd/debug/txsource/workload/queries.go) to include these new methods.

go/consensus/tendermint/registry/registry.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #2841 into master will increase coverage by 0.16%.
The diff coverage is 67.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2841      +/-   ##
==========================================
+ Coverage   67.31%   67.48%   +0.16%     
==========================================
  Files         344      344              
  Lines       33089    33388     +299     
==========================================
+ Hits        22275    22532     +257     
- Misses       7935     7962      +27     
- Partials     2879     2894      +15     
Impacted Files Coverage Δ
go/registry/api/api.go 37.57% <ø> (ø)
go/roothash/api/api.go 75.00% <ø> (ø)
go/staking/api/api.go 71.42% <ø> (ø)
go/registry/api/grpc.go 32.72% <17.64%> (-0.83%) ⬇️
go/consensus/tendermint/roothash/roothash.go 65.54% <33.33%> (-0.01%) ⬇️
go/consensus/tendermint/registry/registry.go 66.92% <53.40%> (-5.90%) ⬇️
go/consensus/tendermint/staking/staking.go 62.85% <56.00%> (-2.77%) ⬇️
go/staking/api/grpc.go 52.61% <64.70%> (-0.33%) ⬇️
go/consensus/tendermint/tendermint.go 68.10% <77.77%> (+1.25%) ⬆️
go/registry/tests/tester.go 91.40% <100.00%> (+0.78%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8522c9...af87d1d. Read the comment docs.

go/consensus/tendermint/registry/registry.go Outdated Show resolved Hide resolved
go/consensus/tendermint/registry/registry.go Outdated Show resolved Hide resolved
go/consensus/tendermint/registry/registry.go Outdated Show resolved Hide resolved
go/consensus/tendermint/registry/registry.go Outdated Show resolved Hide resolved
go/registry/api/api.go Outdated Show resolved Hide resolved
go/staking/api/api.go Outdated Show resolved Hide resolved
@abukosek abukosek force-pushed the andrej/feature/query-events branch 4 times, most recently from 9ef8caa to 6a27230 Compare April 15, 2020 09:20
@abukosek abukosek force-pushed the andrej/feature/query-events branch from 6a27230 to 0b0241c Compare April 15, 2020 09:28
@abukosek abukosek marked this pull request as ready for review April 15, 2020 09:48
@abukosek
Copy link
Contributor Author

Thanks for the review, I've addressed all the comments, so please re-review :)

go/consensus/tendermint/registry/registry.go Outdated Show resolved Hide resolved
go/consensus/tendermint/tendermint.go Outdated Show resolved Hide resolved
go/registry/api/api.go Outdated Show resolved Hide resolved
go/staking/api/api.go Outdated Show resolved Hide resolved
@abukosek abukosek force-pushed the andrej/feature/query-events branch from 0b0241c to d534837 Compare April 15, 2020 10:22
@abukosek abukosek merged commit c154e9f into master Apr 15, 2020
@abukosek abukosek deleted the andrej/feature/query-events branch April 15, 2020 12:04
@kostko
Copy link
Member

kostko commented Apr 15, 2020

Aw you forgot to squash :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support querying for all events at specific height
2 participants