go/runtime/committee: Close delay and reduced resets #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/rt-cmte-client-imp
branch
from
d05b14c to
37af819
Compare
Codecov Report
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
+ Coverage 65.76% 67.01% +1.25%
==========================================
Files 343 342 -1
Lines 32938 32968 +30
==========================================
+ Hits 21663 22095 +432
+ Misses 8557 8165 -392
+ Partials 2718 2708 -10
Continue to review full report at Codecov.
|
ptrus
approved these changes
Apr 6, 2020
kostko
force-pushed
the
kostko/feature/rt-cmte-client-imp
branch
from
37af819 to
33a2e7d
Compare
Yawning
reviewed
Apr 6, 2020
kostko
force-pushed
the
kostko/feature/rt-cmte-client-imp
branch
from
55d0433 to
3af1dec
Compare
Yawning
approved these changes
Apr 6, 2020
abukosek
approved these changes
Apr 7, 2020
Previously a connection was immediately closed, interrupting any in-flight requests. This introduces a configurable (via WithCloseDelay option) close delay so rotated connections are only closed after some time.
Previously each committee election triggered a reset of all connections for that committee. This changes the logic to just bump the committee version in case all the committee members are the same.
kostko
force-pushed
the
kostko/feature/rt-cmte-client-imp
branch
from
f28dbb6 to
08c52fa
Compare
kostko
force-pushed
the
kostko/feature/rt-cmte-client-imp
branch
from
08c52fa to
6bd4dae
Compare
Since gRPC supports the WithResolvers option to specify local resolvers there is no need to use the global resolver registry hack.
kostko
force-pushed
the
kostko/feature/rt-cmte-client-imp
branch
from
6bd4dae to
39484d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2825
go/runtime/committee: Introduce close delay when rotating connections
Previously a connection was immediately closed, interrupting any in-flight
requests. This introduces a configurable (via WithCloseDelay option) close
delay so rotated connections are only closed after some time.
go/runtime/committee: Don't reset committees when they don't change
Previously each committee election triggered a reset of all connections for
that committee. This changes the logic to just bump the committee version in
case all the committee members are the same.