Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close gRPC connections on connection refresh #2826

Closed
kostko opened this issue Apr 7, 2020 · 0 comments · Fixed by #2891
Closed

Don't close gRPC connections on connection refresh #2826

kostko opened this issue Apr 7, 2020 · 0 comments · Fixed by #2891
Labels
c:common Category: common libraries c:deps Category: external dependencies

Comments

@kostko
Copy link
Member

kostko commented Apr 7, 2020 •
edited
Loading

PR #2822 introduced connection refresh on local TLS certificate rotation. This is required because otherwise the server will start rejecting the old client certificates. However, currently connection refresh is implemented by closing and redialing the (virtual) gRPC client connection.

Once grpc/grpc-go#3491 is released (gRPC 1.29) we should just emit an empty resolver state (via UpdateState) to clear any subconnections and then push actual addresses to re-establish them.
@kostko kostko added c:common Category: common libraries c:deps Category: external dependencies s:blocked Status: blocked on other work labels Apr 7, 2020
@kostko kostko removed the s:blocked Status: blocked on other work label May 6, 2020
@kostko kostko mentioned this issue May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:common Category: common libraries c:deps Category: external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/runtime/committee: Don't close gRPC connections on connection refresh oasisprotocol/oasis-core
1 participant
@kostko