Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staking/state: fix DelegationsFor queries #2756

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 9, 2020

Split out from: #2752 (unit test will be added there)

cc @peterjgilbert

@ptrus ptrus force-pushed the ptrus/fix/delegations-query-fix branch from c2dc25d to fe7cbfa Compare March 9, 2020 16:09
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #2756 into master will decrease coverage by 0.15%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2756      +/-   ##
==========================================
- Coverage   62.89%   62.74%   -0.16%     
==========================================
  Files         384      384              
  Lines       36253    36257       +4     
==========================================
- Hits        22802    22749      -53     
- Misses      10560    10617      +57     
  Partials     2891     2891              
Impacted Files Coverage Δ
...o/consensus/tendermint/apps/staking/state/state.go 62.17% <16.66%> (-0.60%) ⬇️
go/storage/metrics.go 72.64% <0.00%> (-10.26%) ⬇️
go/storage/api/root_cache.go 70.11% <0.00%> (-6.90%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/storage/database/database.go 74.56% <0.00%> (-5.27%) ⬇️
go/consensus/api/grpc.go 59.30% <0.00%> (-4.66%) ⬇️
go/storage/mkvs/urkel/urkel.go 85.71% <0.00%> (-3.58%) ⬇️
go/oasis-node/cmd/debug/storage/storage.go 45.08% <0.00%> (-3.47%) ⬇️
go/storage/mkvs/urkel/insert.go 86.39% <0.00%> (-2.73%) ⬇️
go/consensus/tendermint/roothash/roothash.go 68.91% <0.00%> (-2.63%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a65d7...fe7cbfa. Read the comment docs.

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah of course, these aren't stored contiguously

@ptrus ptrus self-assigned this Mar 10, 2020
@ptrus ptrus added the c:bug Category: bug label Mar 10, 2020
@ptrus ptrus merged commit f3dec8e into master Mar 10, 2020
@ptrus ptrus deleted the ptrus/fix/delegations-query-fix branch March 10, 2020 08:45
@ptrus ptrus mentioned this pull request Mar 10, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants