Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txsource: delegation workload #2752

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 4, 2020

Part of: #2506

Delegation workload continuously makes escrow and reclaim escrow transactions between accounts. (note: the escrow balance is only funded at start which effectively means reclaim is also tested as a part of this workload).

Also fixes a bug in delegation queries (extracted into #2756)

TODO:

  • probably should add unit tests for the delegation queries

@ptrus ptrus force-pushed the ptrus/feature/txsource-delegation branch 4 times, most recently from 687562e to 2aac4c7 Compare March 4, 2020 16:17
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #2752 into master will decrease coverage by 0.45%.
The diff coverage is 64.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2752      +/-   ##
==========================================
- Coverage   62.74%   62.29%   -0.46%     
==========================================
  Files         384      385       +1     
  Lines       36257    36412     +155     
==========================================
- Hits        22749    22682      -67     
- Misses      10617    10827     +210     
- Partials     2891     2903      +12     
Impacted Files Coverage Δ
...o/consensus/tendermint/apps/staking/state/state.go 66.66% <ø> (+4.49%) ⬆️
...s-node/cmd/debug/txsource/workload/registration.go 0.00% <0.00%> (-74.44%) ⬇️
...oasis-node/cmd/debug/txsource/workload/workload.go 77.77% <ø> (ø)
...sis-node/cmd/debug/txsource/workload/delegation.go 65.16% <65.16%> (ø)
go/storage/mkvs/urkel/writelog/iterator.go 76.36% <0.00%> (-16.37%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 71.42% <0.00%> (-4.77%) ⬇️
go/worker/storage/service_external.go 47.31% <0.00%> (-4.31%) ⬇️
go/worker/storage/committee/node.go 76.71% <0.00%> (-4.24%) ⬇️
go/runtime/client/watcher.go 73.84% <0.00%> (-2.31%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3dec8e...ecc2ac3. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/txsource-delegation branch 7 times, most recently from f206a2d to 6e57167 Compare March 9, 2020 12:55
@ptrus ptrus marked this pull request as ready for review March 9, 2020 13:27
@ptrus ptrus force-pushed the ptrus/feature/txsource-delegation branch 2 times, most recently from bdd7c36 to a06f7f1 Compare March 10, 2020 10:49
@ptrus ptrus force-pushed the ptrus/feature/txsource-delegation branch 2 times, most recently from 9e18df3 to 7007263 Compare March 10, 2020 12:28
@ptrus ptrus force-pushed the ptrus/feature/txsource-delegation branch from 7007263 to ecc2ac3 Compare March 10, 2020 12:43
@ptrus ptrus self-assigned this Mar 10, 2020
@ptrus
Copy link
Member Author

ptrus commented Mar 10, 2020

thanks for review!

@ptrus ptrus merged commit 798fbe3 into master Mar 10, 2020
@ptrus ptrus deleted the ptrus/feature/txsource-delegation branch March 10, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants