go/genesis: Fix genesis tests and registry sanity checks #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/genesis-tests
branch
from
1e38ba9 to
26edaf3
Compare
Yawning
approved these changes
Jan 29, 2020
kostko
force-pushed
the
kostko/fix/genesis-tests
branch
from
26edaf3 to
8617ded
Compare
Previously the underlying access policies map was passed directly, which led to corruption as the map is mutable. We now create a snapshot of the map before emitting it to the policy watcher.
ptrus
approved these changes
Jan 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #2612 +/- ##
==========================================
+ Coverage 63.34% 63.35% +0.01%
==========================================
Files 359 359
Lines 33841 33863 +22
==========================================
+ Hits 21435 21453 +18
- Misses 9761 9764 +3
- Partials 2645 2646 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2589