go/keymanager: Move Frame structure to enclaverpc package

oasisprotocol · Jan 29, 2020 · 1e38ba9 · 1e38ba9
1 parent d24fe99
commit 1e38ba9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/go/keymanager/api/api.go b/go/keymanager/api/api.go
@@ -180,14 +180,6 @@ func (g *Genesis) SanityCheck() error {
 	return nil
 }
 
-// Frame is the Go analog of the Rust RPC Frame defined in
-// client/src/rpc/client.rs.
-type Frame struct {
-	Session            []byte `json:"session,omitempty"`
-	UntrustedPlaintext string `json:"untrusted_plaintext,omitempty"`
-	Payload            []byte `json:"payload,omitempty"`
-}
-
 func init() {
 	// Old `INSECURE_SIGNING_KEY_PKCS8`.
 	var oldTestKey signature.PublicKey

diff --git a/go/keymanager/api/grpc.go b/go/keymanager/api/grpc.go
@@ -32,9 +32,9 @@ var (
 	Service = enclaverpc.NewService(ModuleName, requestSkipPolicyCheck)
 )
 
-func payloadSkipPolicyCheck(data []byte) (bool, error) {
+func payloadSkipPolicyCheck(data cbor.RawMessage) (bool, error) {
 	// Unpack the payload, get method from Frame.
-	var f Frame
+	var f enclaverpc.Frame
 	if err := cbor.Unmarshal(data, &f); err != nil {
 		return false, fmt.Errorf("unable to unpack Frame: %w", err)
 	}

diff --git a/go/runtime/enclaverpc/api/api.go b/go/runtime/enclaverpc/api/api.go
@@ -5,6 +5,7 @@ import (
 	"context"
 
 	"github.com/oasislabs/oasis-core/go/common"
+	"github.com/oasislabs/oasis-core/go/common/cbor"
 )
 
 // Transport is the EnclaveRPC transport interface.
@@ -18,5 +19,15 @@ type CallEnclaveRequest struct {
 	RuntimeID common.Namespace `json:"runtime_id"`
 	Endpoint  string           `json:"endpoint"`
 
-	Payload []byte `json:"payload"`
+	// Payload is a CBOR-serialized Frame.
+	Payload cbor.RawMessage `json:"payload"`
+}
+
+// Frame is an EnclaveRPC frame.
+//
+// It is the Go analog of the Rust RPC frame defined in client/src/rpc/client.rs.
+type Frame struct {
+	Session            []byte `json:"session,omitempty"`
+	UntrustedPlaintext string `json:"untrusted_plaintext,omitempty"`
+	Payload            []byte `json:"payload,omitempty"`
 }