Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint/apps: Avoid loading all registered runtimes #2544

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 13, 2020

Based on #2504
Fixes #2538

This is a performance optimization to avoid loading a list of all registered
runtimes into memory in cases when only a specific runtime is actually needed.

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #2544 into master will decrease coverage by 0.07%.
The diff coverage is 57.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
- Coverage   67.17%   67.09%   -0.08%     
==========================================
  Files         330      330              
  Lines       30577    30562      -15     
==========================================
- Hits        20539    20506      -33     
- Misses       7482     7498      +16     
- Partials     2556     2558       +2
Impacted Files Coverage Δ
...consensus/tendermint/apps/keymanager/keymanager.go 61.48% <100%> (ø) ⬆️
...consensus/tendermint/apps/registry/transactions.go 44.27% <100%> (+1.54%) ⬆️
go/registry/api/api.go 39.43% <50%> (+0.14%) ⬆️
go/keymanager/api/api.go 68.96% <50%> (ø) ⬆️
go/worker/keymanager/service.go 55.55% <0%> (-22.23%) ⬇️
go/storage/mkvs/urkel/writelog/iterator.go 76.36% <0%> (-16.37%) ⬇️
go/worker/compute/committee/state.go 74.07% <0%> (-11.12%) ⬇️
go/worker/compute/committee/node.go 61.97% <0%> (-4.63%) ⬇️
go/storage/api/root_cache.go 70.11% <0%> (-4.6%) ⬇️
go/consensus/tendermint/apps/registry/query.go 68.75% <0%> (-4.17%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3750b9...a57d52e. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/rt-registration branch from e130bfa to e28cc5e Compare January 14, 2020 12:45
@kostko kostko force-pushed the kostko/feature/opt-reg-lookups branch from c8ef818 to 35c5ec1 Compare January 14, 2020 12:46
@kostko kostko force-pushed the kostko/feature/rt-registration branch 2 times, most recently from a3e3b56 to 80cb5dd Compare January 15, 2020 08:35
This is a performance optimization to avoid loading a list of all registered
runtimes into memory in cases when only a specific runtime is actually needed.
@kostko kostko changed the base branch from kostko/feature/rt-registration to master January 15, 2020 09:09
@kostko kostko force-pushed the kostko/feature/opt-reg-lookups branch from 35c5ec1 to a57d52e Compare January 15, 2020 09:09
@kostko kostko merged commit 529e2a7 into master Jan 15, 2020
@kostko kostko deleted the kostko/feature/opt-reg-lookups branch January 15, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize registry runtime lookups
2 participants