Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize registry runtime lookups #2538

Closed
kostko opened this issue Jan 10, 2020 · 0 comments · Fixed by #2544
Closed

Optimize registry runtime lookups #2538

kostko opened this issue Jan 10, 2020 · 0 comments · Fixed by #2544
Assignees
@kostko
Labels
c:consensus/cometbft Category: CometBFT c:performance Category: performance c:registry Category: entity/node/runtime registry service

Comments

@kostko
Copy link
Member

kostko commented Jan 10, 2020

There are places in the registry code that needlessly iterate over all registered runtimes. These should be replaced with proper runtime lookups.
@kostko kostko added c:registry Category: entity/node/runtime registry service c:consensus/cometbft Category: CometBFT c:performance Category: performance labels Jan 10, 2020
@kostko kostko self-assigned this Jan 10, 2020
@kostko kostko mentioned this issue Jan 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:consensus/cometbft Category: CometBFT c:performance Category: performance c:registry Category: entity/node/runtime registry service
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/consensus/tendermint/apps: Avoid loading all registered runtimes oasisprotocol/oasis-core
1 participant
@kostko