-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: rename compute -> executor #2525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, so this also requires deployment changes (due to configuration flag renames), don't forget to note them in a changelog fragment once you merge to master.
things that remain as "compute":
- the registry node role
Makes sense.
- the registry runtime kind
Makes sense.
- the staking threshold kind
Makes sense.
- things actually referring to processing inputs to outputs
Makes sense.
- one of the drbg contexts
This would likely require updating all the test seeds, so I'm fine with it staying as-is.
a9702e8
to
dd81398
Compare
b0fddd3
to
0f05232
Compare
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
+ Coverage 63.43% 63.68% +0.25%
==========================================
Files 347 347
Lines 32324 32324
==========================================
+ Hits 20505 20587 +82
+ Misses 9250 9182 -68
+ Partials 2569 2555 -14
Continue to review full report at Codecov.
|
0f05232
to
1f5e604
Compare
dd81398
to
48f1d9e
Compare
982da16
to
737b917
Compare
6ca9723
to
e33b02a
Compare
737b917
to
86fe3dc
Compare
e33b02a
to
d4de0e4
Compare
86fe3dc
to
6a5fc61
Compare
d4de0e4
to
db985d3
Compare
6a5fc61
to
5d02095
Compare
5d02095
to
f72edd8
Compare
it was proposed that we rename the "compute" phase (of the txnscheduler, compute, merge workflow) to "executor"
things that remain as "compute":