-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go node: unite compute, merge, and transaction scheduler roles #2514
Conversation
aw this is going to break the byzantine tests isn't it |
815eac4
to
e50b619
Compare
remaining weirdness:
|
a9702e8
to
dd81398
Compare
Codecov Report
@@ Coverage Diff @@
## master #2514 +/- ##
==========================================
- Coverage 67.37% 63.39% -3.98%
==========================================
Files 330 347 +17
Lines 30566 32324 +1758
==========================================
- Hits 20594 20492 -102
- Misses 7461 9247 +1786
- Partials 2511 2585 +74
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the huge coverage difference?
One minor comment, otherwise, this looks good now (except for the coverage thing).
I'll need to tweak all the seeds again in #2504 as the Byzantine node must now wait until epoch 2 due to a change where compute nodes now wait for the key manager runtime to be available first before registering.
dd81398
to
48f1d9e
Compare
alright, I'd better take inventory of what went down in coverage
I'm stopping here. Observations:
|
6ca9723
to
e33b02a
Compare
e33b02a
to
d4de0e4
Compare
now the runtime-dynamic test doesn't work, because you wouldn't be able to register per-runtime storage nodes until the runtimes are registered |
This is so that we have more usable testing schedules with a compute-only role and a merge-only role.
d4de0e4
to
db985d3
Compare
alright, adjusted as the comment there described |
We're removing the separation among registering nodes for the compute, merge, and transaction scheduler roles. You now have to register for and enable all or none of these roles, under a new, broadened, and confusing--you're welcome--term "compute."
non-changelog data:
.enabled
flag is moved to its own package,computeenable
. this is because there are dependencies leading toward the merge worker package, but that would be a weird place to put the compute enable flag.closes #2107