Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd/debug/storage: Add the export sub-command #2495

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Dec 20, 2019

Fixes #1845
Replaces #1847

Mostly straight forward, instead of CBOR I ended up settling on JSON. I doubt we will need to use this tool all that often anyway.

@Yawning Yawning added c:cli Category: command line interface c:storage Category: storage labels Dec 20, 2019
@Yawning Yawning self-assigned this Dec 20, 2019
@Yawning Yawning force-pushed the yawning/feature/1845 branch from dacbe74 to a5834c1 Compare December 20, 2019 11:53
@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #2495 into master will decrease coverage by <.01%.
The diff coverage is 50.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2495      +/-   ##
==========================================
- Coverage   67.14%   67.13%   -0.01%     
==========================================
  Files         323      324       +1     
  Lines       29761    29880     +119     
==========================================
+ Hits        19982    20059      +77     
- Misses       7307     7344      +37     
- Partials     2472     2477       +5
Impacted Files Coverage Δ
go/oasis-node/cmd/debug/storage/storage.go 42.54% <100%> (+1.63%) ⬆️
go/oasis-node/cmd/common/consensus/consensus.go 40.27% <100%> (+0.84%) ⬆️
go/storage/init.go 82.35% <100%> (ø) ⬆️
go/oasis-node/cmd/debug/storage/export.go 46.9% <46.9%> (ø)
go/storage/mkvs/urkel/writelog/iterator.go 76.36% <0%> (-16.37%) ⬇️
go/worker/compute/committee/state.go 74.07% <0%> (-14.82%) ⬇️
go/worker/storage/committee/node.go 73.84% <0%> (-4.09%) ⬇️
go/worker/common/p2p/p2p.go 64.86% <0%> (-2.71%) ⬇️
go/worker/compute/committee/node.go 63.23% <0%> (-2.11%) ⬇️
go/storage/api/grpc.go 68.49% <0%> (-1.37%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2785878...4c7ab1a. Read the comment docs.

@Yawning Yawning force-pushed the yawning/feature/1845 branch 2 times, most recently from adc4bd9 to 83dd21c Compare December 20, 2019 12:05
@Yawning Yawning marked this pull request as ready for review December 20, 2019 12:19
@Yawning Yawning force-pushed the yawning/feature/1845 branch from 83dd21c to 7979a95 Compare December 20, 2019 12:23
@Yawning Yawning force-pushed the yawning/feature/1845 branch from 12d7db5 to 2f96152 Compare December 20, 2019 13:28
The env var will take a comma separated lists of tests that will always
be skipped, so that it is easy to exclude stuff that is broken in a
particular environment while runnint all other tests.
@Yawning Yawning force-pushed the yawning/feature/1845 branch 2 times, most recently from 44f648e to 4c7ab1a Compare December 20, 2019 13:50
@Yawning Yawning merged commit 27de42e into master Dec 20, 2019
@Yawning Yawning deleted the yawning/feature/1845 branch December 20, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add storage export debug subcommand
2 participants