Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage export debug subcommand #1847

Closed
wants to merge 1 commit into from

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 25, 2019

Fixes #1845.

Blocked on #1835.

TODO

  • Merge with genesis dump tool to export all roots for the dumped roothash block(s).

@kostko kostko force-pushed the kostko/feature/storage-export branch from a0ec1a0 to 85a2e24 Compare June 25, 2019 11:38
@kostko kostko force-pushed the kostko/feature/storage-export branch from 85a2e24 to 8b6bb94 Compare October 10, 2019 08:24
@kostko kostko force-pushed the kostko/feature/storage-export branch from 8b6bb94 to 10c2d79 Compare October 10, 2019 08:31
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #1847 into master will decrease coverage by 0.08%.
The diff coverage is 14.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
- Coverage   52.62%   52.54%   -0.09%     
==========================================
  Files         263      264       +1     
  Lines       26489    26550      +61     
==========================================
+ Hits        13941    13951      +10     
- Misses      11090    11141      +51     
  Partials     1458     1458
Impacted Files Coverage Δ
go/common/namespace.go 59.09% <0%> (-17.38%) ⬇️
go/storage/mkvs/urkel/writelog/writelog.go 28.57% <0%> (-7.8%) ⬇️
go/ekiden/cmd/debug/storage/storage.go 6.07% <100%> (+1.04%) ⬆️
go/ekiden/cmd/debug/storage/export.go 13.72% <13.72%> (ø)
go/tendermint/apps/staking/staking.go 50.45% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124b159...10c2d79. Read the comment docs.

@Yawning
Copy link
Contributor

Yawning commented Dec 20, 2019

This can be closed since #2495 has a newer stab at implementing this.

@kostko kostko closed this Dec 23, 2019
@kostko kostko deleted the kostko/feature/storage-export branch December 23, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add storage export debug subcommand
3 participants