Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove staking-related roothash messages #2493

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

kostko
Copy link
Member

@kostko kostko commented Dec 19, 2019

Fixes #2377

@kostko kostko force-pushed the kostko/feature/remove-staking-roothash branch from 1d17b0e to 1a5114c Compare December 19, 2019 10:52
@kostko kostko added the c:breaking/consensus Category: breaking consensus changes label Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #2493 into master will decrease coverage by 0.18%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2493      +/-   ##
==========================================
- Coverage   67.45%   67.27%   -0.19%     
==========================================
  Files         321      321              
  Lines       29768    29503     -265     
==========================================
- Hits        20080    19847     -233     
+ Misses       7242     7224      -18     
+ Partials     2446     2432      -14
Impacted Files Coverage Δ
go/roothash/api/block/header.go 72.97% <ø> (ø) ⬆️
go/staking/api/api.go 50.89% <ø> (ø) ⬆️
go/common/version/version.go 84% <ø> (ø) ⬆️
...o/consensus/tendermint/apps/staking/state/state.go 68.39% <ø> (-0.14%) ⬇️
go/staking/tests/debug/debug_stake.go 60% <ø> (ø) ⬆️
go/roothash/tests/tester.go 96.49% <ø> (-1.1%) ⬇️
go/roothash/api/commitment/compute.go 77.41% <ø> (ø) ⬆️
go/consensus/tendermint/apps/roothash/roothash.go 68.68% <0%> (-2.57%) ⬇️
go/roothash/api/commitment/pool.go 70.5% <0%> (-0.42%) ⬇️
go/roothash/api/api.go 61.11% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b309de...1a5114c. Read the comment docs.

@kostko kostko merged commit 98ae5c2 into master Dec 19, 2019
@kostko kostko deleted the kostko/feature/remove-staking-roothash branch December 19, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove staking-related roothash messages
2 participants