Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove staking-related roothash messages #2377

Closed
kostko opened this issue Nov 13, 2019 · 0 comments · Fixed by #2493
Closed

Remove staking-related roothash messages #2377

kostko opened this issue Nov 13, 2019 · 0 comments · Fixed by #2493
Assignees
@kostko
Labels
c:roothash Category: root hash service c:staking Category: staking

Comments

@kostko
Copy link
Member

kostko commented Nov 13, 2019

There is no longer a plan to support direct manipulation of the staking accounts from the runtimes (in order to isolate the runtimes from corrupting the consensus layer).

To reduce complexity, we should remove the staking-related roothash messages. The general roothash message mechanism can stay as-is since it may be useful in the future, but any commits with non-empty messages should be rejected for now.
@kostko kostko added c:roothash Category: root hash service c:staking Category: staking labels Nov 13, 2019
@kostko kostko self-assigned this Nov 27, 2019
pro-wh added a commit that referenced this issue Dec 10, 2019
@pro-wh
go tendermint staking: adjust total supply in runtime transfer
f7213e8 
We previously left the total supply inconsistent when transferring
tokens to/from a runtime. Fix that to adjust the total supply
accordingly when transferring.

It was also proposed to move these transferred tokens to/from
per-runtime holding areas for bookkeeping. That remains a good
idea.

It's proposed in #2377 to dismantle this whole runtime transfer
system. So with any luck, none of this will be used after all.
@pro-wh pro-wh mentioned this issue Dec 10, 2019
Merged
pro-wh added a commit that referenced this issue Dec 10, 2019
@pro-wh
go tendermint staking: adjust total supply in runtime transfer
71df126 
We previously left the total supply inconsistent when transferring
tokens to/from a runtime. Fix that to adjust the total supply
accordingly when transferring.

It was also proposed to move these transferred tokens to/from
per-runtime holding areas for bookkeeping. That remains a good
idea.

It's proposed in #2377 to dismantle this whole runtime transfer
system. So with any luck, none of this will be used after all.
pro-wh added a commit that referenced this issue Dec 12, 2019
@pro-wh
go tendermint staking: adjust total supply in runtime transfer
f321f9b 
We previously left the total supply inconsistent when transferring
tokens to/from a runtime. Fix that to adjust the total supply
accordingly when transferring.

It was also proposed to move these transferred tokens to/from
per-runtime holding areas for bookkeeping. That remains a good
idea.

It's proposed in #2377 to dismantle this whole runtime transfer
system. So with any luck, none of this will be used after all.
@kostko kostko mentioned this issue Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:roothash Category: root hash service c:staking Category: staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove staking-related roothash messages oasisprotocol/oasis-core
1 participant
@kostko