-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/runtime/client: Make sure Query works with RoundLatest #4217
Conversation
57619e0
to
4ac9cae
Compare
Codecov Report
@@ Coverage Diff @@
## master #4217 +/- ##
==========================================
- Coverage 69.13% 68.63% -0.51%
==========================================
Files 411 411
Lines 47507 47514 +7
==========================================
- Hits 32846 32612 -234
- Misses 10601 10852 +251
+ Partials 4060 4050 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deveopers, be aware that passing RoundInvalid now no longer errors out, if anyone was depending on that (:grimacing:)
oh, overlooked this: this is a breaking change for the API. although I guess the versioning rather tracks chain semantics instead. probably want to have a non-empty changelog for this though @kostko |
So it doesn't change any API exposed to clients (as those already handled RoundLatest correctly), but it does indeed change the history API which is used internally. But yeah someone could be using this API in their own thing as well, so maybe it should be breaking? Or should it be internal? And this will be in 21.3 anyway, so a major version bump.
The changelog is empty because this fixes a bug introduced in #4210 (which will be part of the same release). But yeah maybe for the history API change? |
Added a changelog entry in #4218. |
Update changelog entry for #4217
No description provided.