Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: rename compute -> executor #2525

Merged
merged 2 commits into from
Jan 17, 2020
Merged

go: rename compute -> executor #2525

merged 2 commits into from
Jan 17, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Jan 8, 2020

it was proposed that we rename the "compute" phase (of the txnscheduler, compute, merge workflow) to "executor"

things that remain as "compute":

  • the registry node role
  • the registry runtime kind
  • the staking threshold kind
  • things actually referring to processing inputs to outputs
  • one of the drbg contexts

@pro-wh pro-wh requested a review from kostko January 8, 2020 00:57
@pro-wh pro-wh added the c:breaking/consensus Category: breaking consensus changes label Jan 8, 2020
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, so this also requires deployment changes (due to configuration flag renames), don't forget to note them in a changelog fragment once you merge to master.

things that remain as "compute":

  • the registry node role

Makes sense.

  • the registry runtime kind

Makes sense.

  • the staking threshold kind

Makes sense.

  • things actually referring to processing inputs to outputs

Makes sense.

  • one of the drbg contexts

This would likely require updating all the test seeds, so I'm fine with it staying as-is.

@pro-wh pro-wh force-pushed the pro-wh/feature/onerole branch 2 times, most recently from a9702e8 to dd81398 Compare January 8, 2020 23:03
@pro-wh pro-wh force-pushed the pro-wh/feature/executor branch from b0fddd3 to 0f05232 Compare January 8, 2020 23:19
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #2525 into master will increase coverage by 0.25%.
The diff coverage is 79.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2525      +/-   ##
==========================================
+ Coverage   63.43%   63.68%   +0.25%     
==========================================
  Files         347      347              
  Lines       32324    32324              
==========================================
+ Hits        20505    20587      +82     
+ Misses       9250     9182      -68     
+ Partials     2569     2555      -14
Impacted Files Coverage Δ
go/registry/api/runtime.go 38.7% <ø> (ø) ⬆️
go/roothash/api/commitment/txnscheduler.go 77.77% <ø> (ø) ⬆️
go/worker/executor/tests/tester.go 85% <ø> (ø)
go/worker/txnscheduler/service.go 29.41% <ø> (ø) ⬆️
go/roothash/api/commitment/merge.go 80.95% <ø> (ø) ⬆️
go/runtime/client/tests/tester.go 100% <ø> (ø) ⬆️
go/storage/api/root_cache.go 70.11% <ø> (ø) ⬆️
go/worker/executor/committee/state.go 74.07% <ø> (ø)
go/worker/merge/committee/state.go 100% <ø> (ø) ⬆️
go/oasis-test-runner/oasis/runtime.go 0% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194461b...f72edd8. Read the comment docs.

@pro-wh pro-wh force-pushed the pro-wh/feature/executor branch from 0f05232 to 1f5e604 Compare January 10, 2020 00:59
@pro-wh pro-wh force-pushed the pro-wh/feature/onerole branch from dd81398 to 48f1d9e Compare January 10, 2020 22:00
@pro-wh pro-wh force-pushed the pro-wh/feature/executor branch 2 times, most recently from 982da16 to 737b917 Compare January 14, 2020 22:33
@pro-wh pro-wh force-pushed the pro-wh/feature/onerole branch from 6ca9723 to e33b02a Compare January 15, 2020 23:03
@pro-wh pro-wh force-pushed the pro-wh/feature/executor branch from 737b917 to 86fe3dc Compare January 15, 2020 23:03
@pro-wh pro-wh force-pushed the pro-wh/feature/onerole branch from e33b02a to d4de0e4 Compare January 16, 2020 22:28
@pro-wh pro-wh force-pushed the pro-wh/feature/executor branch from 86fe3dc to 6a5fc61 Compare January 16, 2020 22:28
@pro-wh pro-wh force-pushed the pro-wh/feature/onerole branch from d4de0e4 to db985d3 Compare January 16, 2020 23:57
@pro-wh pro-wh force-pushed the pro-wh/feature/executor branch from 6a5fc61 to 5d02095 Compare January 16, 2020 23:58
@pro-wh pro-wh changed the base branch from pro-wh/feature/onerole to master January 17, 2020 00:58
@pro-wh pro-wh force-pushed the pro-wh/feature/executor branch from 5d02095 to f72edd8 Compare January 17, 2020 01:00
@pro-wh pro-wh merged commit 92e4c37 into master Jan 17, 2020
@pro-wh pro-wh deleted the pro-wh/feature/executor branch January 17, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants