Tweak the search field based on design input #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/tweak-search-field
branch
from
ae5cfb2 to
d95955e
Compare
lukaw3d
reviewed
Jul 7, 2023
src/app/components/Search/index.tsx
Outdated
| if (hasProblem) { | ||
| const timeout = setTimeout(() => { | ||
| setItsTimeToAct(true) | ||
| }, 500) |
There was a problem hiding this comment.
(I dont like this pattern much. I'd validate either instantly, or on submit)
There was a problem hiding this comment.
Actually we validate instantly in the sense that the search button is disabled right away; we just don't want to shove the error message to the face of the user. (Hopefully he will keep typing and won't even have to see it at all.)
This was referenced Jul 7, 2023
csillag
force-pushed
the
csillag/tweak-search-field
branch
from
0d2753f to
c0255ea
Compare
csillag
force-pushed
the
csillag/tweak-search-field
branch
from
c0255ea to
198acab
Compare
csillag
force-pushed
the
csillag/tweak-search-field
branch
from
198acab to
19e243b
Compare
lukaw3d
approved these changes
Jul 7, 2023
csillag
force-pushed
the
csillag/tweak-search-field
branch
2 times, most recently
from
db6c885 to
86e06fb
Compare
csillag
force-pushed
the
csillag/tweak-search-field
branch
from
86e06fb to
2736a4c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add animation when showing/hiding search suggestionsAdd animation when showing/hiding the error messageMove some if the customizations to a higher level, into a dedicated (styled) component or into the theme itself