Network proposal votes: add search by validator name

[csillag]

This adds the search feature for the network proposal vote list.

[github-actions]

Deployed to Cloudflare Pages

Latest commit:	9dc098cdaa3ef6b472c421779bd01ebca2304fb6
Status:	✅ Deploy successful!
Preview URL:	https://eb6f4240.oasis-explorer.pages.dev

[lukaw3d]

Instead of T = string, lets do something like

explorer/src/app/utils/storage.ts

Line 18 in 61c87ee

const get = <T extends keyof StorageType>(key: T): StorageType[T] | undefined => {

in the future

[csillag]

Also search looks weird:

* shadow doesn't look right

* message bellow(its background) is somehow wider than the search box itself

This has been extensively reviewed by @donouwens . Everything has been adjusted as he requested. I am open to changes though, if there are any specific requests.

[donouwens]

Highlight part looks kind of weird, I was searching for "mainnet-upgrade" and it highlights half of "-" as well?

When we have first introduced the highlights, someone (probably @donouwens ?) has requested me to increase the padding, so we always highlight half a character extra, on both sides. It's all in the CSS.

Should we adjust it, @donouwens ?

I don't recall this tbh. It does not seem logical to highlight sections that are not part of the search query

[donouwens]

Should we add proposal example in the suggestion bar bellow the search bar:

Good question. Technically it would make sense, but it's a very small niche, most users don't care about it. I think it would just draw focus away from more important things, like txs, accounts, blocks, etc.

But I defer this to @donouwens , too.

I would say the search bar here is self-explanatory. Users are 'deep' into the Explorer so we can reasonably expect them to know what they'd be searching for (unlike with the main search bar of the Explorer). My vote would be to not include suggestions.

[donouwens]

Also search looks weird:

* shadow doesn't look right

* message bellow(its background) is somehow wider than the search box itself

This has been extensively reviewed by @donouwens . Everything has been adjusted as he requested. I am open to changes though, if there are any specific requests.

The width and radius of the dropdown do not seem to match in the screenshot indeed. Could you match the width and radius to match the input field (visually), please?

[csillag]

It does not seem logical to highlight sections that are not part of the search query

OK, reduced padding from 4px to 2px.
Before:

After:

[csillag]

I would say the search bar here is self-explanatory. Users are 'deep' into the Explorer so we can reasonably expect them to know what they'd be searching for (unlike with the main search bar of the Explorer). My vote would be to not include suggestions.

@donouwens , I think @lubej was actually speaking about the main search bar of the Explorer. Right?

(However, Don, your interpretation is also understandable, since PR is about adding another search bar besides that one...)

[donouwens]

I would say the search bar here is self-explanatory. Users are 'deep' into the Explorer so we can reasonably expect them to know what they'd be searching for (unlike with the main search bar of the Explorer). My vote would be to not include suggestions.

@donouwens , I think @lubej was actually speaking about the main search bar of the Explorer. Right?

(However, Don, your interpretation is also understandable, since PR is about adding another search bar besides that one...)

Ahhh, misinterpreted the message indeed. Sorry. We can add it, on desktop it's no problem, but mobile might make it tricky with the width (I would not want this to go over 2 lines tbh). Send you design on Slack @csillag

[csillag]

The width and radius of the dropdown do not seem to match in the screenshot indeed. Could you match the width and radius to match the input field (visually), please?

OK, updated to:

[csillag]

We can add it, on desktop it's no problem, but mobile might make it tricky with the width (I would not want this to go over 2 lines tbh).

On further discussion, @donouwens 's verdict is:

I [...] prefer to keep it out. [...]
do not incorporate the suggestion in the dropdown

So I guess we don't need to do anything about this, for now.

[lubej]

Apart from few small nits, LGTM