-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format?
See also: |
@PHILO-HE |
Let's address this issue to Gazelle v1.4 release. |
Hi @weiting-chen, thanks for your reminding. |
.github/workflows/unittests.yml
Outdated
mvn clean install -N | ||
cd arrow-data-source | ||
mvn clean install -DskipTests -Dbuild_arrow=OFF | ||
cd .. | ||
mvn clean package -P full-scala-compiler -Phadoop-2.7.4 -am -pl native-sql-engine/core -DskipTests -Dbuild_arrow=OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Phadoop-2.7.4 is required since the default Hadoop version has been changed to 3.2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reverted the changes. Thanks!
arrow-data-source/pom.xml
Outdated
<dependency> | ||
<groupId>org.apache.logging.log4j</groupId> | ||
<artifactId>log4j-1.2-api</artifactId> | ||
<version>2.17.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change version to 2.17.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just changed the version to 2.17.1. Thanks!
@weiting-chen, please have a validation on Jenkins uint tests. You mentioned there is a change in Jenkins script that needs to be reset for upgrade test. |
Done to update Jenkins script, please help to submit an unit test request in Jenkins to verify if the PR can also work in Jenkins. |
@weiting-chen will merge this first to get jenkins running |
No description provided.