Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-687]remove exclude log4j when running ut #688

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

weiting-chen
Copy link
Collaborator

What changes were proposed in this pull request?

  1. Exclude spark core's log4j library in pom.xml
    Closed log4j 1.2.17 in spark-core #687
  2. Add script to remove the exclude for mvn test support

How was this patch tested?

Compile will pass after adding -DskipTests
If the developers need to run unit test, they must remove the exclude code in the pom

@github-actions
Copy link

#687

@weiting-chen weiting-chen requested a review from zhouyuan January 10, 2022 07:58
@zhouyuan zhouyuan merged commit 24b5015 into oap-project:master Jan 10, 2022
zhouyuan pushed a commit to zhouyuan/native-sql-engine that referenced this pull request Jan 10, 2022
* remove exclude log4j when running ut

* Modify hadoop 2.7 ut to the right hadoop dependency version 2.7.4
zhouyuan added a commit that referenced this pull request Jan 10, 2022
* [NSE-684] BufferedOutputStream causes massive futex system calls (#685)

* [NSE-400] Fix the bug for negative decimal data (#686)

* Fix the bug for positive decimal data

* Fix format

* Fix the unit test for 'SPARK-22348: table cache should do partition batch pruning (whole-stage-codegen on)'

* [NSE-687]remove exclude log4j when running ut (#688)

* remove exclude log4j when running ut

* Modify hadoop 2.7 ut to the right hadoop dependency version 2.7.4

Co-authored-by: Hongze Zhang <[email protected]>
Co-authored-by: haojinIntel <[email protected]>
Co-authored-by: Wei-Ting Chen <[email protected]>
PHILO-HE added a commit to PHILO-HE/gazelle_plugin that referenced this pull request Jan 19, 2022
zhouyuan pushed a commit that referenced this pull request Jan 20, 2022
* Revert "[NSE-636]Remove log4j1 related unit tests (#646)"

This reverts commit ad4c4e4.

* Revert "[NSE-687]remove exclude log4j when running ut (#688)"

This reverts commit 24b5015.

* Initial commit

* Introduce new version of log4j to arrow

* Introduce new log4j version to NSE core

* Bump log4j version to 2.17.1

* Revert the changes in unittests.yml to enable Hadoop-2.7.4 test

* Add config for log4j 2.x

* Ignore failed unit tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log4j 1.2.17 in spark-core
2 participants