This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-207] fix scala unit tests #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
commented
Jul 6, 2021
| (TreeBuilder.makeLiteral(value.asInstanceOf[java.lang.Long]), resultType) | ||
| val origLongNode = TreeBuilder.makeLiteral(value.asInstanceOf[java.lang.Long]) | ||
| val timestampNode = TreeBuilder.makeFunction( | ||
| "seconds_to_timestamp", Lists.newArrayList(origLongNode), resultType) |
There was a problem hiding this comment.
To fix this issue: Failed to make LLVM module due to Return type of root node int64 does not match that of expression timestamp[us, tz=UTC]
rui-mo
commented
Jul 6, 2021
native-sql-engine/core/src/test/scala/org/apache/spark/sql/test/SharedSparkSession.scala
Show resolved
Hide resolved
rui-mo
commented
Jul 6, 2021
rui-mo
force-pushed
the
wip_fix_ut_3
branch
3 times, most recently
from
350de4f to
aa38b68
Compare
rui-mo
changed the title
rui-mo
commented
Jul 13, 2021
| @@ -193,6 +206,9 @@ case class ColumnarSortExec( | |||
| val hasInput = iter.hasNext | |||
| val res = if (!hasInput) { | |||
| Iterator.empty | |||
| } else if (allLiteral) { | |||
| // If sortOrder are all Literal, no need to do sorting. | |||
| new CloseableColumnBatchIterator(iter) | |||
There was a problem hiding this comment.
for all Literal case
rui-mo
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr:
depends on: oap-project/arrow#26
#207
How was this patch tested?
verified on TPC-DS v1 and v2