Add int32 support and change format of castVarchar #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
rui-mo
changed the title
rui-mo
changed the title
rui-mo
changed the title
|
TPC-DS q12 on double dataset: |
rui-mo
commented
Jul 12, 2021
| CAST_UNARY_UTF8(castVARCHAR, float32, utf8, "%g", NOFMT, nothing) | ||
| CAST_UNARY_UTF8(castVARCHAR, float64, utf8, "%g", NOFMT, nothing) | ||
| CAST_UNARY_UTF8(castVARCHAR, float32, utf8, "%.*f", FMT, FLT_DIG) | ||
| CAST_UNARY_UTF8(castVARCHAR, float64, utf8, "%.*f", FMT, DBL_DIG) |
There was a problem hiding this comment.
@zhouyuan Please take a look at this, thanks!
There was a problem hiding this comment.
can you please make a note here? this is required as Spark has some different behavior as gandiva
zhztheplayer
pushed a commit
that referenced
this pull request
Feb 28, 2022
* add support to int32 type * fix fortmat of cast varchar
zhztheplayer
pushed a commit
that referenced
this pull request
Mar 15, 2022
* add support to int32 type * fix fortmat of cast varchar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed oap-project/gazelle_plugin#405.