Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration: define how application scopes are bound to components #135

Closed
wants to merge 1 commit into from
Closed

configuration: define how application scopes are bound to components #135

wants to merge 1 commit into from

Conversation

hongchaodeng
Copy link
Member

@hongchaodeng hongchaodeng commented Sep 10, 2019 •
edited
Loading

@hongchaodeng
Copy link
Member Author

@mikkelhegn @technosophos
Can you help review this?

@hongchaodeng hongchaodeng mentioned this pull request Sep 11, 2019
Closed
11 tasks
@mikkelhegn
Copy link
Contributor

Looks like this is conflicting with #127 - could we move all changes to that PR and close this one? I will reply on #127

@hongchaodeng
Copy link
Member Author

Hi @mikkelhegn

Sound good to me

@hongchaodeng hongchaodeng deleted the config_scope branch September 13, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonderflow wonderflow wonderflow left review comments

@mikkelhegn mikkelhegn Awaiting requested review from mikkelhegn

@technosophos technosophos Awaiting requested review from technosophos

@vturecek vturecek Awaiting requested review from vturecek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Follow traits schema to specify how app scopes are referenced by components
3 participants
@hongchaodeng @mikkelhegn @wonderflow