Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Follow traits schema to specify how app scopes are referenced by components #130

Open
mikkelhegn opened this issue Sep 6, 2019 · 4 comments
Labels

Comments

@mikkelhegn
Copy link
Contributor

mikkelhegn commented Sep 6, 2019

In the operational (application) configuration, it's not specified how the applicationScopes are referenced: https://github.com/microsoft/hydra-spec/blob/master/6.application_configuration.md#component

Suggesting that we follow the schema defined for traits:
https://github.com/microsoft/hydra-spec/blob/master/6.application_configuration.md#trait

Follow-up to #119

@hongchaodeng
Copy link
Member

Suggesting that we follow the schema defined for traits:
https://github.com/microsoft/hydra-spec/blob/master/6.operational_configuration.md#trait

Thanks for the suggestion.
But in the Configuration definition, it already contains the Scopes definitions in the same level as Components. I think the reason is that Scope could cross Component boundaries. In plain words, involve multiple components.
So my conclusion is that we will keep Scopes definitions as is today, but define references in Components.

@suhuruli suhuruli changed the title Operational (Application) Configuration does not specify how application scopes and components are tied Proposal: Follow traits schema to specify how app scopes are referenced by components Sep 12, 2019
@hongchaodeng
Copy link
Member

hongchaodeng commented Sep 13, 2019

Let's move discussion to https://github.com/microsoft/hydra-spec/issues/144 ?

@mikkelhegn
Copy link
Contributor Author

The problem is that we have only specified how scopes are created as part of an application configuration, not how components are added to a scope, unless we assume every component in an application configuration will be a member of all components in that one application configuration. That however goes against the whole idea of the application scopes.

@hongchaodeng
Copy link
Member

I think the whole idea is to reuse and reduce definitions. In fact I'm fine with either solution. But in last weekly meeting, that was the unanimous decision.
@mikkelhegn Could you join the weekly next time and discuss your concerns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants