This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
WIP add application scopes framework and healthscope #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
force-pushed
the
health-scop
branch
from
7c6f4a0 to
80cd339
Compare
wonderflow
force-pushed
the
health-scop
branch
from
80cd339 to
8c1c0c0
Compare
wonderflow
changed the title
wonderflow
force-pushed
the
health-scop
branch
from
8c1c0c0 to
e981227
Compare
wonderflow
force-pushed
the
health-scop
branch
2 times, most recently
from
7204283 to
001bc53
Compare
wonderflow
force-pushed
the
health-scop
branch
2 times, most recently
from
40b0a9b to
3010f9a
Compare
|
@technosophos I find this PR could be very large, will it hard to review? |
wonderflow
force-pushed
the
health-scop
branch
from
3010f9a to
5cb54e4
Compare
wonderflow
force-pushed
the
health-scop
branch
from
02a80d1 to
a63e9c0
Compare
wonderflow
changed the title
wonderflow
commented
Oct 14, 2019
healthscope/src/main.rs
Outdated
| health_scope_watch.join().unwrap() | ||
| } | ||
|
|
||
| //FIXME: Error(BlockingClientInFutureContext) https://github.com/clux/kube-rs/issues/63 |
There was a problem hiding this comment.
Now we can't get health status response, because the client we invoke didn't implement async. kube-rs/kube#63
It will occur Error(BlockingClientInFutureContext) when we invoke synchronize function in hyper here .
I've tried several ways to work around, they don't work. Could someone more familiar with rust web framework than me give some help?
wonderflow
added
Status: Blocked
wonderflow
force-pushed
the
health-scop
branch
from
b81c95d to
1f4dfa6
Compare
wonderflow
added
Status: Available
wonderflow
changed the title
|
I am holding this PR back until after 1.0.0-alpha.1. |
8 tasks
|
closing this, we move to #367 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly to add application scope framework and health scope
This PR lasts several weeks mostly because the spec is changing.
https://github.com/microsoft/hydra-spec/issues/130
https://github.com/microsoft/hydra-spec/issues/144
https://github.com/microsoft/hydra-spec/pull/133
https://github.com/microsoft/hydra-spec/pull/127
https://github.com/microsoft/hydra-spec/pull/177
https://github.com/microsoft/hydra-spec/pull/196
add application scopes framework
add health scope