Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "fix: revert error to previous protocol (#139) #218

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

codeincontext
Copy link
Collaborator

@codeincontext codeincontext commented Oct 11, 2024

This reverts commit e053b89.

We reverted the protocol changes for error messages like the friendly rate limit message in the Chat. Now that we're using the latest protocol with structured outputs, we need the new version again

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 10:44am

Copy link

github-actions bot commented Oct 11, 2024

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

@codeincontext codeincontext requested a review from stefl October 14, 2024 15:06
Copy link
Contributor

@stefl stefl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on whether the regex needs to match to the end of the line

Copy link

@codeincontext codeincontext merged commit dccba58 into main Oct 15, 2024
13 of 14 checks passed
@codeincontext codeincontext deleted the fix/chat-error-protocol branch October 15, 2024 10:51
@codeincontext codeincontext mentioned this pull request Oct 15, 2024
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants