Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert error to previous protocol #139

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: revert error to previous protocol #139

merged 1 commit into from
Sep 17, 2024

Conversation

mantagen
Copy link
Collaborator

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 8:27am

@mantagen mantagen requested a review from a team September 17, 2024 08:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

simonrose121
simonrose121 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@simonrose121 simonrose121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Following up on my point on slack, can we remove the scope "(protocol)" from the PR title?

@mantagen mantagen changed the title fix(protocol): revert error to previous protocol fix: revert error to previous protocol Sep 17, 2024
@mantagen mantagen merged commit e053b89 into production Sep 17, 2024
12 checks passed
@mantagen mantagen deleted the hotfix/revert-protocol-errors branch September 17, 2024 08:32
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mantagen added a commit that referenced this pull request Oct 3, 2024
@mantagen
fix: revert error to previous protocol (#139)
ea40fd5
codeincontext added a commit that referenced this pull request Oct 10, 2024
@codeincontext
Revert "fix: revert error to previous protocol (#139)"
4970cc1 
This reverts commit e053b89.
codeincontext added a commit that referenced this pull request Oct 11, 2024
@codeincontext
Revert "fix: revert error to previous protocol (#139)"
ab1e125 
This reverts commit e053b89.
codeincontext added a commit that referenced this pull request Oct 15, 2024
@codeincontext
Revert "fix: revert error to previous protocol (#139)"
77d4be3 
This reverts commit e053b89.
codeincontext added a commit that referenced this pull request Oct 15, 2024
@codeincontext
fix: revert "fix: revert error to previous protocol (#139) (#218)
dccba58
@codeincontext codeincontext mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrose121 simonrose121 simonrose121 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mantagen @oak-machine-user @simonrose121