Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only run PR workflows in PRs #16

Closed
wants to merge 2 commits into from
Closed

fix: only run PR workflows in PRs #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ebbeab
fix: don't run PR update jobs on main or production branches
simonrose121 Aug 28, 2024
ab98f93
fix: only run on pull requests
simonrose121 Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
retention-days: 30
- name: Comment PR with playwright report
uses: thollander/actions-comment-pull-request@v2
if: ${{ !cancelled() }}
if: ${{ !cancelled() && github.event_name == 'pull_request' }}
with:
pr_number: ${{ steps.ref_from_sha.outputs.pr_number }}
message: |
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/post_deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: Deployment Actions

on: deployment_status
on:
pull_request:
branches: ["*"]

jobs:
dump_github_event:
Expand All @@ -10,7 +12,6 @@ jobs:
update_pr_description:
# Only want to run on success, otherwise it might be "pending", or "failure".
# Filter out storybook deployments and temporarily Netlify deployments
if: ${{ (github.event.deployment.ref != 'main') && (github.event.deployment_status.state == 'success') && !startsWith(github.event.deployment_status.environment, 'storybook')}}
name: Add deploy URL to PR description
runs-on: ubuntu-latest
steps:
Expand Down
Loading