Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only run PR workflows in PRs #16

Closed
wants to merge 2 commits into from
Closed

fix: only run PR workflows in PRs #16

wants to merge 2 commits into from

Conversation

simonrose121
Copy link
Collaborator

Description

  • Only runs the playwright job to update the pull request if the workflow is run from a pull request.
  • Only runs the workflow to set the deployment URL in PRs.

How to test

  1. In this PR, the workflows should run and update the PR description and leave a comment (playwright).
  2. When merged, they shouldn't run on main, production or any branches.

@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 10:35am

@notion-workspace Notion Workspace
Copy link

Create new repo

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mantagen
mantagen approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@mantagen mantagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeincontext
Copy link
Collaborator

Just a heads up, I can't see the comment on this PR. Are you sure that github.event_name can be pull_request?

@simonrose121 simonrose121 marked this pull request as draft August 28, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantagen mantagen mantagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonrose121 @codeincontext @mantagen