-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite table to functional component #326
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oacore/dashboard/a9xlzrg5o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather create a few components that accept raw data and just render it and do the data/request management somehow separate.
@viktor-yakubiv It's basically the second commit b7036c6 The idea is to make the table as dumb as possible. It's kind of part of #260. There should be two table hooks - |
@viktor-yakubiv Sorry it's one big commit. I didn't have a clear idea of how to refactor it so I used different approaches and everything ended up in one commit. I don't expect you to go through the whole code. Maybe just take a brief look if it is now more readable. I am not sure about it, to be honest. I managed to create small component/hooks and reduce the size of the table file. The most important change is useDymanicData hook. I moved data loading outside of the table and all related state is passed as a props. This can help us to use static data as well and eventually removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will wait and handle conflicts here. No problem. Thanks for looking into it. :) |
c003a15
to
065ed6d
Compare
5e13b23
to
aed8a4a
Compare
I hope I resolved all conflicts correctly. Feel free to assign any bug with a table directly to me. |
Thanks a lot for maintaining all the conflicts for such a long time! 👍 I hope this PR is as big improvement as we hope 😄 |
No description provided.