-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form for requesting premium version #336
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oacore/dashboard/k71gpq284 |
bfbb275
to
c7b70e7
Compare
@Joozty could you please do some early review? It seems to be okay but needs to be prettified and properly integrated. |
5a4e0ef
to
c540f54
Compare
If there is no data, or an error happened: * exporting functionality gets disabled; * the table footer becomes hidden. If the happened error is a Payment Required kind, the note about payment is shown.
c540f54
to
84b7cc8
Compare
@Joozty I consider this finished and ready for the review. The first commit fixes a bug introduced by #337. Although, I have to test UX of the form itself and consider @mcancellieri's remark that it's quite long. Also, I need to test actual form sending and see how it works, I missed a few hidden inputs and additional values to make it work. |
Add storing request error in a property if there is one. Improves `404 Not Found` handling. Adds `402 Payment Required` handling. Does not store the error if no data found.
Passes error with the data if there is any. If the error status is 402 but there is no data, error is cleared.
Some texts that are not written using markdown flavoured syntax should be explicitly marked as plain text (*.txt). However, we would like to support frontmatter for additional information, so we reuse yaml-frontmatter-loader for *.txt files.
Adds a simple README file and Webpack resolver for the directory.
If there is no data, or an error happened: * exporting functionality gets disabled; * the table footer becomes hidden. If the happened error is a Payment Required kind, the note about payment is shown. Disables search if error appeared.
0d4f28d
to
14adfc3
Compare
@mcancellieri I wonder if you have time to review this. If you do not I have no other way than merge it as is. Go through the commits, most of them are just preparation for the feature that is integrated by the last one. @oacore/front-end I still experience problems. The request-premium form appears only after page reload or on the second visit, i.e. when the deposit dates page was opened once, no error appears but on the second step it's shown. |
Adds a letter template for requesting premium features for an organisation. Adds notes about free account. Adds `letters` and `billing` modules into `texts`. Cross-integrates new messages with `depositing` and `doi` text-modules.
The form constructs an email for requesting premium features.
The module controls billing, stores messages and forms for handling paid-only features. It's connected to the global Store, uses every single part of it.
If there is no data, or an error happened: * exporting functionality gets disabled; * the table footer becomes hidden. If the happened error is a Payment Required kind, the note about payment is shown. Disables search if error appeared.
14adfc3
to
cbd093f
Compare
The bug is sorted. There is another minor bug when you click on the row. The white sidebar appears, and it's not possible to close it. I would keep it for now and handle it later. |
If there is no data, or an error happened: * exporting functionality gets disabled; * the table footer becomes hidden. If the happened error is a Payment Required kind, the note about payment is shown. Disables search if error appeared.
5e13b23
to
aed8a4a
Compare
Working onThe form for requesting premium. Read commit messages for the detailed description.402
as a base used for testing only. This must be merged tomaster
first and #335 aligned after.