Async circuits, pt 2 - witness and transaction callback #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
changed the title
mitschabaude
commented
Feb 29, 2024
There was a problem hiding this comment.
some actual changes here
src/lib/provable-core/exists.ts
Outdated
There was a problem hiding this comment.
introducing async witness
src/lib/provable.ts
Outdated
There was a problem hiding this comment.
introducing async witness
mitschabaude
commented
Feb 29, 2024
src/snarky.d.ts
Outdated
There was a problem hiding this comment.
additions to snarky-ml interface
Trivo25
approved these changes
Mar 4, 2024
| ): Promise<Transaction>; | ||
| function transaction( | ||
| senderOrF: DeprecatedFeePayerSpec | (() => void), | ||
| fOrUndefined?: () => void | ||
| senderOrF: DeprecatedFeePayerSpec | (() => Promise<void>), |
There was a problem hiding this comment.
Might be about time that we remove the old deprecated private key as fee payer spec
There was a problem hiding this comment.
good idea. I'll do an API cleanup PR before v1 that removes all the long deprecated stuff
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the two remaining dependencies to support async contract methods:
Provable.asyncWitness()Mina.transactioncallback asyncSince these two changes ended up creating a huge diff, and the next PR will do so again, I chose to defer actual async methods to yet another PR
snarky: o1-labs/snarky#839
mina: to be seen if this can be included in an existing PR
bindings: o1-labs/o1js-bindings#253