Async circuit, pt. 3 - contract methods #1477
Conversation
There was a problem hiding this comment.
I deleted this entire folder, it was a left-over from CI tests in the Mina repo that don't exist anymore
src/lib/caller.unit-test.ts
Outdated
There was a problem hiding this comment.
deleted this test, don't think it was still useful
There was a problem hiding this comment.
this example was too similar to reducer-composite.ts, I'm trying to purge examples that don't really add anything, as they are a burden to maintain
src/lib/mina/transaction.ts
Outdated
There was a problem hiding this comment.
an actual change here. I think the try-catch was unused because it didn't await the promise, so removed it
There was a problem hiding this comment.
most of the actual changes in this file!
| function method<K extends string, T extends SmartContract>( | ||
| target: T & { | ||
| [k in K]: (...args: any) => Promise<void>; | ||
| }, |
There was a problem hiding this comment.
the decorator type now enforces a particular function signature of the method that is decorated:
(...args: any) => Promise<void>| 'design:returntype', | ||
| target, | ||
| methodName | ||
| ); |
There was a problem hiding this comment.
we no longer infer the method return type, instead there is @method.returns(...)
| result = await assertPromise( | ||
| method.apply(this, clonedArgs), | ||
| noPromiseError | ||
| ); |
There was a problem hiding this comment.
throughout the wrapped method, we are now awaiting the method result and also throwing a helpful runtime error if it's not returning a promise
| * }); | ||
| * tx.sign([senderKey, zkAppKey]); | ||
| * ``` | ||
| */ | ||
| deploy({ | ||
| async deploy({ |
There was a problem hiding this comment.
deploy() needs to be async because it calls init(), which can be a method so might be async
src/lib/proof-system.ts
Outdated
There was a problem hiding this comment.
ZKProgram was already supporting async methods at runtime, but not at the type level. This here is the change that forces the method type to be async.
mitschabaude
changed the title
Closes #735
Most breaking change ever -- requires all smart contract and zkprogram methods to be async.
This PR is stacked behind #1450 and #1468 where most of the internal changes were already made
Here, there aren't much changes apart from
@methodandZKProgram; introducing@method.returns(..)for methods with a return valueTODO: