buffer: properly apply offset on fast path

PR-URL: nodejs#54391
nxtedition · Aug 15, 2024 · f0ba68b · f0ba68b
1 parent ccf05ef
commit f0ba68b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
@@ -1479,9 +1479,10 @@ uint32_t FastWriteString(Local<Value> receiver,
   CHECK(offset <= dst.length());
   CHECK(dst.length() - offset <= std::numeric_limits<uint32_t>::max());
 
-  max_length = std::min<uint32_t>(dst.length() - offset, max_length);
+  const auto size = std::min(
+      {static_cast<uint32_t>(dst.length() - offset), max_length, src.length});
 
-  memcpy(dst_data, src.data, max_length);
+  memcpy(dst_data + offset, src.data, size);
 
   return max_length;
 }