buffer: properly apply dst offset and src length on fast path #54391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
ronag
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 15, 2024
ronag
force-pushed
the
fast-string-missing-offset
branch
from
e708a48
to
41c2d89
Compare
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 15, 2024
ronag
force-pushed
the
fast-string-missing-offset
branch
2 times, most recently
from
f0ba68b
to
ea45c6c
Compare
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 15, 2024
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 15, 2024
ronag
force-pushed
the
fast-string-missing-offset
branch
from
ea45c6c
to
9795353
Compare
ronag
force-pushed
the
fast-string-missing-offset
branch
from
9795353
to
bbafef7
Compare
ronag
changed the title
|
Fast-track has been requested by @ronag. Please 👍 to approve. |
benjamingr
approved these changes
Aug 15, 2024
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54391 +/- ##
==========================================
+ Coverage 86.33% 87.08% +0.74%
==========================================
Files 648 648
Lines 182290 182310 +20
Branches 34812 34985 +173
==========================================
+ Hits 157385 158757 +1372
+ Misses 18213 16822 -1391
- Partials 6692 6731 +39
|
anonrig
approved these changes
Aug 15, 2024
ronag
added
the
commit-queue
jakecastelli
approved these changes
Aug 15, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2c14615 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
Refs: #54311 (comment) PR-URL: #54391 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 21, 2024
Refs: #54311 (comment) PR-URL: #54391 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.