-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #139 #140
Fix for #139 #140
Conversation
Please don't merge this yet, there is an issue regarding the |
@bastimeyer brilliant that you're helping with this! One thing, can you not introduce changes to whitespace? See our .editorconfig, indentation should be four spaces. EditorConfig is really handy, if you install the plugin for your editor it'll automatically pick up what the indentation should be :). |
Where did I change the indentation style? |
Ugh sorry 👍, I thought those four spaces were tabs because of how they look in the diff |
Please ignore what I was talking about earlier. I wasn't aware, that this "package.json bug" was working as intended for the whole time. Should I squeeze these commits or is this ok? |
The handleWinApp and handleMacApp methods now both work again after the recent platform changes.
233afda
to
9a9971c
Compare
Oh, lucky you :/. So this is ready yeah? |
Nevermind... squeezed it... What I also wanted to ask: should the copyright informations be mandatory? Right now they are and this is what caused my earlier confusion (paired the the npm issue and the package.json stuff ofc) |
Oh, didn't see your post.. It should be good now |
This does fix the winIco but breaks compiling osx on 1.0.0; paths can't be resolved correctly when using the macIcns option; omitting that option results in an error that the plist file can't be found :s |
I can't reproduce any of these said errors. Yes, these methods are not covered by any test cases, but I tested it manually by using different configurations, and even though, all I did was adding the _forEachPlatforms call. So the build logic shouldn't be affected by these changes. |
@lucienimmink did you see the reply above? |
I assume it's fixed, we'll patch if not ASAP |
This fixes #139...
handleMacApp
andhandleWinApp
haven't been upgraded after the platform name changes.