Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winIco doesn't work in version 1.0.0 #139

Closed
lucienimmink opened this issue Dec 15, 2014 · 6 comments · Fixed by #140
Closed

winIco doesn't work in version 1.0.0 #139

lucienimmink opened this issue Dec 15, 2014 · 6 comments · Fixed by #140

Comments

@lucienimmink
Copy link

Updated to version 1.0.0 but now the icons are not set for win32 and win64 (using the win meta target).
@adam-lynch
Copy link
Contributor

Thanks. Might be the fact we changed how platforms work that broke it. I assume you mean options.winIco.

@lucienimmink
Copy link
Author

Yes that is the one.

@adam-lynch
Copy link
Contributor

See this @danthewolfe

bastimeyer added a commit to bastimeyer/nw-builder that referenced this issue Dec 15, 2014
@bastimeyer
Fixed winIco option... resolves nwutils#139
0ac2fdc 
handleWinApp was still checking for the old platform name
@bastimeyer bastimeyer mentioned this issue Dec 15, 2014
Merged
@cbabos
Copy link

cbabos commented Dec 18, 2014

The patch is working correctly. When will be there a release from this version? Thank you for this great tool.

@adam-lynch
Copy link
Contributor

@cbabos ASAP once there's consensus that it doesn't break anything else

@cbabos
Copy link

cbabos commented Dec 18, 2014

Thank you Adam!

adam-lynch added a commit that referenced this issue Dec 18, 2014
@adam-lynch
Merge pull request #140 from bastimeyer/multi-win-osx-platforms-fix
62a47d9 
Fix for #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #139 bastimeyer/nw-builder
3 participants
@cbabos @adam-lynch @lucienimmink