-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build stalls for nwjs 0.12.0 #204
Comments
I've also tried building with http://dl.nwjs.io/, seems to show that |
Same on windows 8.1 x64 (Using grunt) |
I haven't tried it on nodejs. I was under the impression that nwjs 0.12.0 only supported io.js. My cache directory looks like this:
Anything wrong with it? |
The directory structure is how it's supposed to be. |
it seems it comes from here https://github.com/mllrsohn/node-webkit-builder/blob/master/lib/utils.js#L87 |
This is the error: |
@bastimeyer maybe you can switch back to latest version of |
That's what I had in mind, and it also lets the copyFile promise resolve, but now there is no release folder |
Seems like they've copied the code of the old version of I think I'm just too tired and confused from this point on... I'll have a further look at it tomorrow |
I was hacking around my node_modules folder (where I installed
and it miraculously compiled using I tried it again, and got:
but, it's probably something weird with my setup. Going to try clean it up and try and replicate the successful compilation. |
These are the changes: taktran@d25f2a1 But still getting the |
@taktran The This is what is failing without bumping Bumping it also fails (although the build "succeeds"), because of the old edit: |
Nice catch @bastimeyer Modifying The |
FWIW, just hit this on a Mac trying to build a Mac up. This fix worked for me as well, but requires that I patch the installed |
Just fixed it and opened a PR over there. See the reference above my post here. |
@taktran @tswicegood Could you please try out the latest rm -rf node_modules/graceful-fs-extra
git clone https://github.com/adam-lynch/graceful-fs-extra.git node_modules/graceful-fs-extra
cd node_modules/graceful-fs-extra
npm install edit: |
@bastimeyer work for me update to graceful-fs-extra 1.0.6 |
@bastimeyer works for me too, after removing
Thanks! 🎉 |
@bastimeyer author of I'd love to fix this, but I am unable to reproduce :( |
@jprichardson Just tested it again and it seems to work now (at least for me - using git clone -b fs-extra-dependency-changes https://github.com/bastimeyer/node-webkit-builder.git
cd node-webkit-builder
npm install |
@bastimeyer Almost there, I changed Thanks a lot @jprichardson and @bastimeyer !! |
@bastimeyer -- confirmed that this works for me. Thanks! |
So what is the best way to run the builder now? I just tried
|
I'm trying to build an app using
nwbuild
(v1.0.11), but it stalls on the lineCreate release folder in /Users/../osx64
I'm running
Which returns
The file that gets generated is only about 281kb.
It does run when I run with the
-r
flag though ie,The build worked for node-webkit 0.8.6.
It might be an iojs issue (#201), but that seems to have been fixed in
node-webkit-builder
v1.0.11.Any ideas?
The text was updated successfully, but these errors were encountered: