Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build stalls for nwjs 0.12.0 #204

Closed
taktran opened this issue Mar 12, 2015 · 24 comments · Fixed by adam-lynch/graceful-fs-extra#1
Closed

Build stalls for nwjs 0.12.0 #204

taktran opened this issue Mar 12, 2015 · 24 comments · Fixed by adam-lynch/graceful-fs-extra#1

Comments

@taktran
Copy link

taktran commented Mar 12, 2015

I'm trying to build an app using nwbuild (v1.0.11), but it stalls on the line Create release folder in /Users/../osx64

I'm running

nwbuild -p osx64 -v 0.12.0 -o ../webkitbuilds dist

Which returns

$ nwbuild -p osx64 -v 0.12.0 -o ../webkitbuilds dist; date
Using v0.12.0
Create cache folder in /Users/.../node_modules/node-webkit-builder/cache/0.12.0
Downloading: http://dl.nwjs.io/v0.12.0/nwjs-v0.12.0-osx-x64.zip
  downloading [====================] 100% 0.0s

Create release folder in /Users/.../osx64

The file that gets generated is only about 281kb.

It does run when I run with the -r flag though ie,

nwbuild -p osx64 -v 0.12.0 -o ../webkitbuilds -r dist

The build worked for node-webkit 0.8.6.

It might be an iojs issue (#201), but that seems to have been fixed in node-webkit-builder v1.0.11.

Any ideas?

@taktran
Copy link
Author

taktran commented Mar 12, 2015

I've also tried building with -v 0.12.0-rc1, but that didn't work either.

http://dl.nwjs.io/, seems to show that 0.12.0 is newer than 0.12.0-rc1 anyway.

@felicienfrancois
Copy link

Same on windows 8.1 x64 (Using grunt)

@bastimeyer
Copy link
Contributor

Is this io.js related? Or does this also happen while using nodejs?
@taktran Could you please paste the content of the cache directory? As you already said, this seems to be related to #201 and this was the part that failed. Maybe it's another issue with ncp, but I'm not sure.

@taktran
Copy link
Author

taktran commented Mar 12, 2015

I haven't tried it on nodejs. I was under the impression that nwjs 0.12.0 only supported io.js.

My cache directory looks like this:

$ ls -laR node_modules/node-webkit-builder/cache
total 0
drwxr-xr-x   3 ttt  staff  102 12 Mar 15:42 .
drwxr-xr-x  10 ttt  staff  340 12 Mar 15:42 ..
drwxr-xr-x   3 ttt  staff  102 12 Mar 17:07 0.12.0

node_modules/node-webkit-builder/cache/0.12.0:
total 0
drwxr-xr-x  3 ttt  staff  102 12 Mar 17:07 .
drwxr-xr-x  3 ttt  staff  102 12 Mar 15:42 ..
drwxr-xr-x  6 ttt  staff  204 12 Mar 17:09 osx64

node_modules/node-webkit-builder/cache/0.12.0/osx64:
total 17248
drwxr-xr-x  6 ttt  staff      204 12 Mar 17:09 .
drwxr-xr-x  3 ttt  staff      102 12 Mar 17:07 ..
-rw-r--r--@ 1 ttt  staff     6148 12 Mar 17:09 .DS_Store
-rw-r--r--  1 ttt  staff   937334 12 Mar 17:07 credits.html
-rwxr-xr-x  1 ttt  staff  7881932 12 Mar 17:07 nwjc
drwxr-xr-x  3 ttt  staff      102 12 Mar 17:07 nwjs.app

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app:
total 0
drwxr-xr-x  3 ttt  staff  102 12 Mar 17:07 .
drwxr-xr-x  6 ttt  staff  204 12 Mar 17:09 ..
drwxr-xr-x  7 ttt  staff  238 12 Mar 17:07 Contents

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents:
total 16
drwxr-xr-x  7 ttt  staff   238 12 Mar 17:07 .
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 ..
drwxr-xr-x  7 ttt  staff   238 12 Mar 17:07 Frameworks
-rw-r--r--  1 ttt  staff  2768 12 Mar 17:07 Info.plist
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 MacOS
-rw-r--r--  1 ttt  staff     8 12 Mar 17:07 PkgInfo
drwxr-xr-x  7 ttt  staff   238 12 Mar 17:07 Resources

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks:
total 120
drwxr-xr-x  7 ttt  staff    238 12 Mar 17:07 .
drwxr-xr-x  7 ttt  staff    238 12 Mar 17:07 ..
-rwxr-xr-x  1 ttt  staff  57404 12 Mar 17:07 crash_inspector
drwxr-xr-x  5 ttt  staff    170 12 Mar 17:07 nwjs Framework.framework
drwxr-xr-x  3 ttt  staff    102 12 Mar 17:07 nwjs Helper EH.app
drwxr-xr-x  3 ttt  staff    102 12 Mar 17:07 nwjs Helper NP.app
drwxr-xr-x  3 ttt  staff    102 12 Mar 17:07 nwjs Helper.app

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Framework.framework:
total 144768
drwxr-xr-x   5 ttt  staff       170 12 Mar 17:07 .
drwxr-xr-x   7 ttt  staff       238 12 Mar 17:07 ..
drwxr-xr-x   3 ttt  staff       102 12 Mar 17:07 Libraries
drwxr-xr-x  62 ttt  staff      2108 12 Mar 17:07 Resources
-rwxr-xr-x   1 ttt  staff  74120224 12 Mar 17:07 nwjs Framework

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Framework.framework/Libraries:
total 2360
drwxr-xr-x  3 ttt  staff      102 12 Mar 17:07 .
drwxr-xr-x  5 ttt  staff      170 12 Mar 17:07 ..
-rwxr-xr-x  1 ttt  staff  1207800 12 Mar 17:07 ffmpegsumo.so

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Framework.framework/Resources:
total 35448
drwxr-xr-x  62 ttt  staff      2108 12 Mar 17:07 .
drwxr-xr-x   5 ttt  staff       170 12 Mar 17:07 ..
-rw-r--r--   1 ttt  staff     12480 12 Mar 17:07 AHEM____.TTF
-rw-r--r--   1 ttt  staff      3020 12 Mar 17:07 ChromiumAATTest.ttf
drwxr-xr-x   3 ttt  staff       102 12 Mar 17:07 English.lproj
-rw-r--r--   1 ttt  staff       375 12 Mar 17:07 am.pak
-rw-r--r--   1 ttt  staff       357 12 Mar 17:07 ar.pak
-rw-r--r--   1 ttt  staff       556 12 Mar 17:07 bg.pak
-rw-r--r--   1 ttt  staff       629 12 Mar 17:07 bn.pak
-rw-r--r--   1 ttt  staff       296 12 Mar 17:07 ca.pak
-rw-r--r--   1 ttt  staff       290 12 Mar 17:07 cs.pak
-rw-r--r--   1 ttt  staff       257 12 Mar 17:07 da.pak
-rw-r--r--   1 ttt  staff       323 12 Mar 17:07 de.pak
-rw-r--r--   1 ttt  staff       546 12 Mar 17:07 el.pak
-rw-r--r--   1 ttt  staff       242 12 Mar 17:07 en-GB.pak
-rw-r--r--   1 ttt  staff       242 12 Mar 17:07 en-US.pak
-rw-r--r--   1 ttt  staff       283 12 Mar 17:07 es-419.pak
-rw-r--r--   1 ttt  staff       294 12 Mar 17:07 es.pak
-rw-r--r--   1 ttt  staff       286 12 Mar 17:07 et.pak
-rw-r--r--   1 ttt  staff       385 12 Mar 17:07 fa.pak
-rw-r--r--   1 ttt  staff       297 12 Mar 17:07 fi.pak
-rw-r--r--   1 ttt  staff       261 12 Mar 17:07 fil.pak
-rw-r--r--   1 ttt  staff       314 12 Mar 17:07 fr.pak
-rw-r--r--   1 ttt  staff       546 12 Mar 17:07 gu.pak
-rw-r--r--   1 ttt  staff       592 12 Mar 17:07 hi.pak
-rw-r--r--   1 ttt  staff       313 12 Mar 17:07 hr.pak
-rw-r--r--   1 ttt  staff       344 12 Mar 17:07 hu.pak
-rw-r--r--   1 ttt  staff  10457856 12 Mar 17:07 icudtl.dat
-rw-r--r--   1 ttt  staff       293 12 Mar 17:07 id.pak
-rw-r--r--   1 ttt  staff       306 12 Mar 17:07 it.pak
-rw-r--r--   1 ttt  staff       319 12 Mar 17:07 iw.pak
-rw-r--r--   1 ttt  staff       354 12 Mar 17:07 ja.pak
-rw-r--r--   1 ttt  staff       634 12 Mar 17:07 kn.pak
-rw-r--r--   1 ttt  staff       313 12 Mar 17:07 ko.pak
-rw-r--r--   1 ttt  staff       338 12 Mar 17:07 lt.pak
-rw-r--r--   1 ttt  staff       310 12 Mar 17:07 lv.pak
-rw-r--r--   1 ttt  staff       372 12 Mar 17:07 missingImage.png
-rw-r--r--   1 ttt  staff       844 12 Mar 17:07 ml.pak
-rw-r--r--   1 ttt  staff       531 12 Mar 17:07 mr.pak
-rw-r--r--   1 ttt  staff       298 12 Mar 17:07 ms.pak
-rw-r--r--   1 ttt  staff       286 12 Mar 17:07 nl.pak
-rw-r--r--   1 ttt  staff       258 12 Mar 17:07 no.pak
-rw-r--r--   1 ttt  staff   7439016 12 Mar 17:07 nw.pak
-rw-r--r--   1 ttt  staff       311 12 Mar 17:07 pl.pak
-rw-r--r--   1 ttt  staff       291 12 Mar 17:07 pt-BR.pak
-rw-r--r--   1 ttt  staff       294 12 Mar 17:07 pt-PT.pak
-rw-r--r--   1 ttt  staff       340 12 Mar 17:07 ro.pak
-rw-r--r--   1 ttt  staff       451 12 Mar 17:07 ru.pak
-rw-r--r--   1 ttt  staff       341 12 Mar 17:07 sk.pak
-rw-r--r--   1 ttt  staff       279 12 Mar 17:07 sl.pak
-rw-r--r--   1 ttt  staff       413 12 Mar 17:07 sr.pak
-rw-r--r--   1 ttt  staff       272 12 Mar 17:07 sv.pak
-rw-r--r--   1 ttt  staff       261 12 Mar 17:07 sw.pak
-rw-r--r--   1 ttt  staff       649 12 Mar 17:07 ta.pak
-rw-r--r--   1 ttt  staff       704 12 Mar 17:07 te.pak
-rw-r--r--   1 ttt  staff        92 12 Mar 17:07 textAreaResizeCorner.png
-rw-r--r--   1 ttt  staff       523 12 Mar 17:07 th.pak
-rw-r--r--   1 ttt  staff       341 12 Mar 17:07 tr.pak
-rw-r--r--   1 ttt  staff       459 12 Mar 17:07 uk.pak
-rw-r--r--   1 ttt  staff       337 12 Mar 17:07 vi.pak
-rw-r--r--   1 ttt  staff       264 12 Mar 17:07 zh-CN.pak
-rw-r--r--   1 ttt  staff       264 12 Mar 17:07 zh-TW.pak

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Framework.framework/Resources/English.lproj:
total 8
drwxr-xr-x   3 ttt  staff   102 12 Mar 17:07 .
drwxr-xr-x  62 ttt  staff  2108 12 Mar 17:07 ..
-rw-r--r--   1 ttt  staff  3390 12 Mar 17:07 HttpAuth.nib

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper EH.app:
total 0
drwxr-xr-x  3 ttt  staff  102 12 Mar 17:07 .
drwxr-xr-x  7 ttt  staff  238 12 Mar 17:07 ..
drwxr-xr-x  5 ttt  staff  170 12 Mar 17:07 Contents

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper EH.app/Contents:
total 16
drwxr-xr-x  5 ttt  staff   170 12 Mar 17:07 .
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 ..
-rw-r--r--  1 ttt  staff  1338 12 Mar 17:07 Info.plist
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 MacOS
-rw-r--r--  1 ttt  staff     8 12 Mar 17:07 PkgInfo

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper EH.app/Contents/MacOS:
total 24
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 .
drwxr-xr-x  5 ttt  staff   170 12 Mar 17:07 ..
-rwxr-xr-x  1 ttt  staff  8552 12 Mar 17:07 nwjs Helper EH

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper NP.app:
total 0
drwxr-xr-x  3 ttt  staff  102 12 Mar 17:07 .
drwxr-xr-x  7 ttt  staff  238 12 Mar 17:07 ..
drwxr-xr-x  5 ttt  staff  170 12 Mar 17:07 Contents

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper NP.app/Contents:
total 16
drwxr-xr-x  5 ttt  staff   170 12 Mar 17:07 .
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 ..
-rw-r--r--  1 ttt  staff  1338 12 Mar 17:07 Info.plist
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 MacOS
-rw-r--r--  1 ttt  staff     8 12 Mar 17:07 PkgInfo

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper NP.app/Contents/MacOS:
total 24
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 .
drwxr-xr-x  5 ttt  staff   170 12 Mar 17:07 ..
-rwxr-xr-x  1 ttt  staff  8552 12 Mar 17:07 nwjs Helper NP

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper.app:
total 0
drwxr-xr-x  3 ttt  staff  102 12 Mar 17:07 .
drwxr-xr-x  7 ttt  staff  238 12 Mar 17:07 ..
drwxr-xr-x  5 ttt  staff  170 12 Mar 17:07 Contents

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper.app/Contents:
total 16
drwxr-xr-x  5 ttt  staff   170 12 Mar 17:07 .
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 ..
-rw-r--r--  1 ttt  staff  1326 12 Mar 17:07 Info.plist
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 MacOS
-rw-r--r--  1 ttt  staff     8 12 Mar 17:07 PkgInfo

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Frameworks/nwjs Helper.app/Contents/MacOS:
total 24
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 .
drwxr-xr-x  5 ttt  staff   170 12 Mar 17:07 ..
-rwxr-xr-x  1 ttt  staff  8552 12 Mar 17:07 nwjs Helper

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/MacOS:
total 24
drwxr-xr-x  3 ttt  staff   102 12 Mar 17:07 .
drwxr-xr-x  7 ttt  staff   238 12 Mar 17:07 ..
-rwxr-xr-x  1 ttt  staff  8552 12 Mar 17:07 nwjs

node_modules/node-webkit-builder/cache/0.12.0/osx64/nwjs.app/Contents/Resources:
total 760
drwxr-xr-x  7 ttt  staff     238 12 Mar 17:07 .
drwxr-xr-x  7 ttt  staff     238 12 Mar 17:07 ..
-rw-r--r--  1 ttt  staff   12480 12 Mar 17:07 AHEM____.TTF
-rw-r--r--  1 ttt  staff    3020 12 Mar 17:07 ChromiumAATTest.ttf
-rw-r--r--  1 ttt  staff     372 12 Mar 17:07 missingImage.png
-rw-r--r--  1 ttt  staff  360065 12 Mar 17:07 nw.icns
-rw-r--r--  1 ttt  staff      92 12 Mar 17:07 textAreaResizeCorner.png

Anything wrong with it?

@bastimeyer
Copy link
Contributor

The directory structure is how it's supposed to be.
Btw: it's also failing for me on linux x64. I didn't test the OSX archives in #201. I'm so stupid 😿
Let me debug this quickly...

@felicienfrancois
Copy link

it seems it comes from here https://github.com/mllrsohn/node-webkit-builder/blob/master/lib/utils.js#L87
the copy function from graceful-fs-extra never call the callback

@bastimeyer
Copy link
Contributor

This is the error:
https://github.com/jprichardson/node-fs-extra/blob/0.13.0/package.json#L41
fs-extra (v0.13.0) is using the old version of ncp
Let me test this again with the latest version of fs-extra (inside graceful-fs-extra)

@felicienfrancois
Copy link

@bastimeyer maybe you can switch back to latest version of fs-extra as they are now using graceful-fs

@bastimeyer
Copy link
Contributor

That's what I had in mind, and it also lets the copyFile promise resolve, but now there is no release folder

@bastimeyer
Copy link
Contributor

Seems like they've copied the code of the old version of ncp into https://github.com/jprichardson/node-fs-extra/blob/0.16.5/lib/_copy.js
See https://github.com/jprichardson/node-fs-extra/blob/0.16.5/CHANGELOG.md#0150--2015-01-21

I think I'm just too tired and confused from this point on... I'll have a further look at it tomorrow

@taktran
Copy link
Author

taktran commented Mar 12, 2015

I was hacking around my node_modules folder (where I installed node-webkit-builder), and following @felicienfrancois's advice of just using fs-extra, ie,

  • removed graceful-fs in node_modules/node-webkit-builder/package.json and deleted it from node_modules/node-webkit-builder/node_modules
  • Replaced line 1 of node_modules/node-webkit-builder/lib/utils.js to have var fs = require('fs-extra');
  • Replaced line 5 of node_modules/node-webkit-builder/lib/index.js to have var fs = require('fs-extra');

and it miraculously compiled using node_modules/node-webkit-builder/bin/nwbuild. It's really hacky and might not be able to replicated, but I it feels so close!

I tried it again, and got:

[ { [Error: ENFILE: file table overflow, open '/Users/.../osx64/SAM.app/Contents/Resources/app.nw/node_modules/grunt-cli/node_modules/findup-sync/node_modules/glob/test/root.js']
    errno: -23,
    code: 'ENFILE',
    syscall: 'open',
    path: '/Users/.../osx64/SAM.app/Contents/Resources/app.nw/node_modules/grunt-cli/node_modules/findup-sync/node_modules/glob/test/root.js' } ]

but, it's probably something weird with my setup. Going to try clean it up and try and replicate the successful compilation.

taktran added a commit to taktran/node-webkit-builder that referenced this issue Mar 12, 2015
@taktran
Copy link
Author

taktran commented Mar 12, 2015

These are the changes: taktran@d25f2a1

But still getting the ENFILE error. Needs further investigation.

@bastimeyer
Copy link
Contributor

@taktran The graceful- packages were made to prevent this specific problem. https://github.com/isaacs/node-graceful-fs

This is what is failing without bumping fs-extra inside graceful-fs-extra:
https://github.com/jprichardson/node-fs-extra/blob/0.13.0/lib/copy.js#L47
@adam-lynch Why actually? I think we're injecting the "good" ncp version from here?
https://github.com/adam-lynch/graceful-fs-extra/blob/master/index.js#L2

Bumping it also fails (although the build "succeeds"), because of the old ncp version code they've copied. There's also an open issue over there: jprichardson/node-fs-extra#115

edit:
Changing line 3 in node_modules/graceful-fs-extra/node_modules/fs-extra/lib/copy.js from var ncp = require('ncp').ncp to var ncp = require('graceful-ncp').ncp fixes all issues for me.

@taktran
Copy link
Author

taktran commented Mar 13, 2015

Nice catch @bastimeyer

Modifying node_modules/graceful-fs-extra/node_modules/fs-extra/lib/copy.js kind of works for me. When compiling code with npm install --production (ie, without dev dependencies), it works consistently. I still get the ENFILE error when the nw node_modules folder has dev dependencies though. I'm guessing it's because there are too many files being copied over when my node_modules contains dev dependencies.

The graceful-ncp hack works for me for now.

@tswicegood
Copy link

FWIW, just hit this on a Mac trying to build a Mac up. This fix worked for me as well, but requires that I patch the installed fs-extra library after an install. Any thoughts on how to fix this so a straight install works?

@bastimeyer
Copy link
Contributor

Just fixed it and opened a PR over there. See the reference above my post here.

@bastimeyer
Copy link
Contributor

@taktran @tswicegood Could you please try out the latest graceful-fs-extra version from the git master branch?

rm -rf node_modules/graceful-fs-extra
git clone https://github.com/adam-lynch/graceful-fs-extra.git node_modules/graceful-fs-extra
cd node_modules/graceful-fs-extra
npm install

edit:
New version was bumped... Just clean your npm cache and reinstall all dependencies.

@siuying
Copy link

siuying commented Mar 15, 2015

@bastimeyer work for me update to graceful-fs-extra 1.0.6

@taktran
Copy link
Author

taktran commented Mar 15, 2015

@bastimeyer works for me too, after removing node_modules/node-webkit-builder, npm installing, and then running

node_modules/node-webkit-builder/bin/nwbuild -p osx64 -v 0.12.0 -o ../webkitbuilds dist

Thanks! 🎉

@jprichardson
Copy link

@bastimeyer author of fs-extra here. ncp was copied over, fixed and patched. See https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md (specifically changes in 0.16). You can see that the copy does indeed use graceful-fs. https://github.com/jprichardson/node-fs-extra/blob/0.16.5/lib/_copy.js#L3 along with many other changes over ncp as seen here: https://github.com/jprichardson/node-fs-extra/commits/0.16.5/lib/_copy.js

I'd love to fix this, but I am unable to reproduce :(

@bastimeyer
Copy link
Contributor

@jprichardson Just tested it again and it seems to work now (at least for me - using io.js v1.5.1). I must have done something wrong a couple of days ago while trying to investigate the problem here (had an empty osx build folder, don't know why).
That actually means that graceful-fs-extra is not needed anymore.
@taktran @siuying @tswicegood
Sorry for bothering again, but could someone verify this who had these build issues before? I pushed the changes to my fork. Thanks!
bastimeyer@960252a

git clone -b fs-extra-dependency-changes https://github.com/bastimeyer/node-webkit-builder.git
cd node-webkit-builder
npm install

@siuying
Copy link

siuying commented Mar 16, 2015

@bastimeyer Almost there, I changed fs-extra to 0.16.5 and it work as expected.

Thanks a lot @jprichardson and @bastimeyer !!

@tswicegood
Copy link

@bastimeyer -- confirmed that this works for me. Thanks!

@taktran
Copy link
Author

taktran commented May 3, 2015

So what is the best way to run the builder now?

I just tried 1.0.11 and bastimeyer/node-webkit-builder#fs-extra-dependency-changes, but I still get the ENFILE error eg,

[ { [Error: ENFILE: file table overflow, open '/Users/.../nodejs/dist/app/bower_components/foundation/scss/foundation/components/_sub-nav.scss']
    errno: -23,
    code: 'ENFILE',
    syscall: 'open',
    path: '/Users/.../nodejs/dist/app/bower_components/foundation/scss/foundation/components/_sub-nav.scss' } ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants