Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxyquire dependency injections #1

Merged
merged 1 commit into from
Mar 14, 2015

Conversation

bastimeyer
Copy link
Contributor

This should fix nwutils/nw-builder#204

The issue was that the graceful-ncp dependency injection didn't work at all, because ncp was required inside submodules of fs-extra.
This also does only work with fs-extra v1.3.0...

adam-lynch added a commit that referenced this pull request Mar 14, 2015
Fix proxyquire dependency injections
@adam-lynch adam-lynch merged commit 997c9a0 into adam-lynch:master Mar 14, 2015
@adam-lynch
Copy link
Owner

Thanks.

This also does only work with fs-extra v1.3.0...

Huh? fs-extra is on version 0.16.5

@adam-lynch
Copy link
Owner

I would publish this right now but I think I'll wait for you to confirm it's ok just in case.

@bastimeyer
Copy link
Contributor Author

They've made some changes in fs-extra and removed the ncp dependency and copied over the code into their own module. I did only test this with the version which is currently set inside the package.json (v1.3.0).

If you want to upgrade to v1.6.5, then you need to modify my changes a bit, because the ncp code which needs to be replaced is now here...

bastimeyer@4a93e39#diff-168726dbe96b3ce427e7fedce31bb0bcR4
ncp => ./_copy (see here, no guarantee though)

@adam-lynch
Copy link
Owner

Sorry, I'm getting a little confused because of the version numbers. Do you mean [email protected] and [email protected]?

Also, they've copied ncp over into their own code so they could fix it, right? Then is this module needed anymore?

@bastimeyer
Copy link
Contributor Author

Do you mean [email protected] and [email protected]?

Yes

Also, they've copied ncp over into their own code so they could fix it, right?

The copy method is still broken (at least while using io.js) without the graceful ncp injection.

Then is this module needed anymore?

It actually never worked until now.

@adam-lynch
Copy link
Owner

Ok, thanks.

It actually never worked until now.

Oh, wow.


Ok, so I'll lock it down to 0.13.0 to be safe for now

@adam-lynch
Copy link
Owner

1.0.6 published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build stalls for nwjs 0.12.0
2 participants