Download progress bar using progress.
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see there is another issue on this (#78). Prithee? |
|
See #79 for an explanation as to why we are not currently updating |
|
Ah I see! That's no problem then, I can rebase #69, would that be alright? |
corwin-of-amber
force-pushed
the
download-progress
branch
from
010cdee
to
3e5e4d4
Compare
|
Forced-pushed this to be a rebase of #69, using |
corwin-of-amber
force-pushed
the
download-progress
branch
from
3e5e4d4
to
ca00c1a
Compare
TheJaredWilcurt
approved these changes
Jul 29, 2020
|
Yay 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having encountered #26 and seeing that others keep hitting the same "huh?!", I suggest having indication that the script is downloading the ~160MB of NWjs.
Some preparation seems to have existed, in the form of
createBar(...)(usingmultimeter). It seems to be a rather outdated package, and does not take into account the width of the terminal. I replaced it with the more standardprogress. Upgradingdownloadis required for receiving thedownloadProgressevents.(This PR replaces #69.)