Feature: download progress bar on install script. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to point out that progress reporting is easier with newer versions of |
|
This is too old. I am making a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having encountered #26 and seeing that others keep hitting the same "huh?!", I suggest having indication that the script is downloading the ~100MB of NWjs.
Some preparation seems to have existed, in the form of
createBar(...). I plugged into this. Since progress only makes sense for download, I placed the vars for total and downloaded bytes in the HTTP-install conditional branch. Some global vars may become redundant (these were not used before either).