Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When NVM_DIR is a symlink, nvm_ls breaks #617

Open
ljharb opened this issue Jan 19, 2015 · 2 comments
Open

When NVM_DIR is a symlink, nvm_ls breaks #617

ljharb opened this issue Jan 19, 2015 · 2 comments
Labels
bugs Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D testing Stuff related to testing nvm itself.

Comments

@ljharb
Copy link
Member

ljharb commented Jan 19, 2015

Per some of the discussion on here: #616 (comment) as reported by @patrick-steele-idem

Solution is to add -L to the find command inside nvm_ls. The tricky part is writing a test for it :-)
@ljharb ljharb added the bugs Oh no, something's broken :-( label Jan 19, 2015
@ljharb ljharb added testing Stuff related to testing nvm itself. pull request wanted This is a great way to contribute! Help us out :-D labels Apr 5, 2015
@ljharb ljharb mentioned this issue Oct 7, 2015
Closed
@singlow singlow mentioned this issue Oct 14, 2015
Open
@ljharb
Copy link
Member Author

ljharb commented Nov 28, 2015

This seems to also be causing some of the issues incorrectly reported on #855.

@ljharb ljharb mentioned this issue Mar 9, 2016
Closed
@ljharb ljharb mentioned this issue May 8, 2016
Closed
tornewuff added a commit to tornewuff/dotfiles that referenced this issue Jun 18, 2016
@tornewuff
Work around nvm not supporting NVM_DIR being a symlink.
d8dca78 
Use realpath to get the actual location. See
nvm-sh/nvm#617 for the bug.
@ljharb ljharb mentioned this issue Dec 29, 2016
Closed
@ljharb ljharb mentioned this issue Jan 17, 2017
Open
@ljharb ljharb mentioned this issue Sep 29, 2017
Closed
@CristianCantoro
Copy link
Contributor

Temporary workaround, in .zprofile (or .zshrc, if you prefer):

 # you can use the real path instead of the command f you prefer
export NVM_DIR="$(realpath $HOME/.nvm)"   
[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"

travi added a commit to travi/dotfiles that referenced this issue Jan 30, 2018
@travi
explicitly referenced the nvm path
9fac159 
based on the workaround mentioned here: nvm-sh/nvm#617 (comment)
@ljharb ljharb mentioned this issue Apr 30, 2018
Closed
compilenix added a commit to compilenix/dotfiles that referenced this issue Jun 14, 2018
@compilenix
nvm brakes if part of the path is a symlink
9ced7c5 
see nvm-sh/nvm#617 (comment)
@ljharb ljharb mentioned this issue Apr 20, 2019
Closed
This was referenced May 8, 2019
Closed
Closed
@ljharb ljharb mentioned this issue Jan 8, 2020
Draft
@ljharb ljharb mentioned this issue Jun 13, 2020
Closed
This was referenced Sep 13, 2020
Closed
Closed
@ljharb ljharb mentioned this issue Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugs Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D testing Stuff related to testing nvm itself.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @CristianCantoro