-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io.js
support
#616
io.js
support
#616
Conversation
…remote node [foo]` only show node versions.
…vm ls iojs` Also add `nvm_version node` and `nvm_version iojs` support.
checksum still disabled, you can't find a way to do sha-256 reliably? have you tested widely? |
@rvagg I've been primarily focused on getting all the functionality working - I haven't had a chance to test widely. I'm hoping that |
moar file clutter, moar process |
I pulled the branch to try testing it out
iojs is nice. But I should be testing nvm.. Above confusion comes in part because new |
Looks good on Tested:
|
I thought I'd have to write
Nice work! |
This change: - removes a superfluous N/A - fixes the exit code to return 0 unless no version is found - enables `nvm install v1` and similar patterns.
It works! 👿 nvm ls
iojs-v1.0.0
iojs-v1.0.1
iojs-v1.0.2
-> iojs-v1.0.3
v0.8.26
v0.8.27
v0.8.28
v0.10.21
v0.10.22
v0.10.23
v0.10.24
v0.10.25
v0.10.26
v0.10.27
v0.10.28
v0.10.29
v0.10.30
v0.10.31
v0.10.32
v0.10.33
v0.10.34
v0.10.35
v0.11.9
v0.11.11
v0.11.12
v0.11.13
v0.11.14
stable -> 0.10 (-> v0.10.35) (default)
unstable -> 0.11 (-> v0.11.14) (default) |
I'll be merging this shortly, followed by a release of |
Add `io.js` support. This branch adds support for https://github.com/iojs/io.js / https://iojs.org/ The following features should now work: - `nvm install iojs` will install the latest `io.js` version. `nvm ls iojs` and `nvm use iojs` will function as you'd expect. - `nvm install node` will install the latest stable `node` version. `nvm ls node` and `nvm use node` will function as you'd expect. - In general, a specific `io.js` version can be referenced with the "iojs-" prefix. If `node` were to ever release a `v1.0.0`, `v1.0.0` would refer to `node`, and `iojs-v1.0.0` would refer to `io.js`. In the near future, `node-v1.0.0` will also refer to `node` unambiguously. This applies to all `nvm` commands, including working with aliases and `.nvmrc` files. - `io.js`, unlike `node`, does not have a SunOS binary. Please open an issue on https://github.com/iojs/io.js if this is actually a problem for anyone, as currently it seems like this won't be for anybody. **Note**: checksum support upon installation is currently disabled. Relates to nodejs/node#368. **Note**: installation of `io.js` directly from source (via the `-s` option) is not yet enabled. This will be added soon. Relates to nodejs/node#40 nodejs/node#420 Fixes #590
Totally awesome! Thanks for all of the hard work! |
A bit too late to this discussion, but why it is "iojs" and not just "io"? It's inconsistent with "node", which should otherwise be "nodejs" for consistency. |
It would be cool if |
@nikolay it's the same number of letters as "node"? ¯_(ツ)_/¯ It's too late to remove "iojs" (yesterday was the day for that kind of feedback), although I could add "io" as the prefix too in the future if there's enough interest to warrant the complexity. fwiw, if you never install node versions, the prefix shouldn't ever be necessary. @mikeal that's definitely a bug - |
@ljharb strange, none of those work for me:
|
@nikolay then we should ask the same question about binary. For node.js it is node, but for io.js it is iojs. |
@mikeal ◉︵◉ please file an issue with your shell and OS and i'll get to work on a fix, those should all be working. |
Thank you all - it makes sense. By the way, nodebrew adopted "io" - it would be nice to at least support "io" as an alias. I think the team behind io.js picked |
See nodejs/node#28 (comment) for why this is a bad idea. Anyway, this has nothing to do with this issue which is about supporting io.js in nvm. |
For me |
You most likely have an out-of-date nvm version. Invoke: |
@varya what's the SHA of the nvm version you're using? |
That's true. |
@varya have you closed and reopened your shell / re-sourced your bashrc/bash_profile/zshrc? |
Oh, thanks! I should have guessed that this matters. Everything works finely after update. |
Ah, I always forget to do that, heh! I have a |
This branch adds support for https://github.com/iojs/io.js / https://iojs.org/
The following features should now work:
nvm install iojs
will install the latestio.js
version.nvm ls iojs
andnvm use iojs
will function as you'd expect.nvm install node
will install the latest stablenode
version.nvm ls node
andnvm use node
will function as you'd expect.io.js
version can be referenced with the "iojs-" prefix. Ifnode
were to ever release av1.0.0
,v1.0.0
would refer tonode
, andiojs-v1.0.0
would refer toio.js
. In the near future,node-v1.0.0
will also refer tonode
unambiguously. This applies to allnvm
commands, including working with aliases and.nvmrc
files.io.js
, unlikenode
, does not have a SunOS binary. Please open an issue on https://github.com/iojs/io.js if this is actually a problem for anyone, as currently it seems like this won't be for anybody.Note: checksum support upon installation is currently disabled. Relates to nodejs/node#368.
Note: installation of
io.js
directly from source (via the-s
option) is not yet enabled. This will be added soon.Relates to nodejs/node#40 nodejs/node#420
Fixes #590
I'm going to merge and release this after a number of people test this on their own machines - hopefully sometime on the 19th.
Constructive feedback about this feature, or its usage, is welcome. Please keep "+1"'s and comments that add no value to a minimum.