Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.10 into branch-25.02 #1966

Merged
7 commits merged into from
Oct 24, 2024
Merged

Forward-merge branch-24.10 into branch-25.02 #1966

7 commits merged into from
Oct 24, 2024

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Oct 21, 2024

Forward-merge triggered by push to branch-24.10 that creates a PR to keep branch-25.02 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

Usage:
```
pytest tests/scripts/
```

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1954
@rapids-bot rapids-bot bot requested a review from a team as a code owner October 21, 2024 20:09
Copy link
Author

rapids-bot bot commented Oct 21, 2024

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

dagardner-nv and others added 2 commits October 21, 2024 22:12
* Improve milvus startup time bypassing milvus' own `wait_for_started` method which was causing an intermittent delay up to 40s
* Consolidate tests `test_kafka_source_commit` and `test_kafka_source_batch_pipe` these two tests were 80% similar
* Remove the `num_records=100` parameter from `test_kafka_source_batch_pipe`
* Reduce parameters for test `test_http_server.py::test_simple_request` lowering the total number of test combinations from 865 down to 145.
* Update rag pipeline tests to share a common milvus collection, lowering test time from 45s down to 25s

Closes #1948

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1953
- [x] Add a page for using the Morpheus conda packages
- [x] Add documentation for LLM and DFP stages APIs
- [] Update example READMEs (if needed)

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #1964
@rapids-bot rapids-bot bot requested a review from a team as a code owner October 22, 2024 00:38
* Requires PR #1924 to be merged first.

Closes [#1660](#1660)

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1932
ashsong-nv and others added 3 commits October 22, 2024 17:22
…generate_batch_async()` (#1967)

This PR reverts the removal of the `**kwargs` argument from the `NVFoundationLLMClient.generate_batch()` and `generate_batch_async()` methods, which introduced a regression.

Closes #1961 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Ashley Song (https://github.com/ashsong-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #1967
This PR is replacing the `VAULT_HOST` variable with `AWS_ROLE_ARN`. This is required to use the new token service to get AWS credentials.

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Jordan Jacobelli (https://github.com/jjacobelli)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #1962
- Remove all references to the Starter DFP in docs
- Remove classes which only exist for the Starter DFP.
- Remove tests and associated test data for the Starter DFP
- Remove Starter DFP from CLI

Closes #1715
Closes #1713
Closes #1641

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #1903
@dagardner-nv dagardner-nv closed this pull request by merging all changes into branch-25.02 in b0ca5b0 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants