Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Developer and Contributor guide should explain the conda yaml files and when to use them #1660

Closed
2 tasks done
dagardner-nv opened this issue Apr 23, 2024 · 0 comments · Fixed by #1932
Closed
2 tasks done
Assignees
Labels
doc Improvements or additions to documentation

Comments

@dagardner-nv
Copy link
Contributor

How would you describe the priority of this documentation request

High

Please provide a link or source to the relevant docs

https://github.com/nv-morpheus/Morpheus/blob/branch-24.06/docs/source/developer_guide/contributing.md?plain=1#L207

Describe the problems in the documentation

We should document when to use the dev and when to use the all yaml.
In addition, the developer guides recommending -DMORPHEUS_BUILD_EXAMPLES=ON should mention that it requires the all yaml.

(Optional) Propose a correction

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the doc Improvements or additions to documentation label Apr 23, 2024
@dagardner-nv dagardner-nv self-assigned this Apr 23, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Oct 4, 2024
@morpheus-bot-test morpheus-bot-test bot moved this from In Progress to Review - Ready for Review in Morpheus Boards Oct 4, 2024
@mdemoret-nv mdemoret-nv added this to the 24.10 - Release milestone Oct 19, 2024
rapids-bot bot pushed a commit that referenced this issue Oct 22, 2024
* Requires PR #1924 to be merged first.

Closes [#1660](#1660)

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1932
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants