Remove unnecessary flags in Legion CMake build (#932) #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unnecessary flags in Legion CMake build. The flag --root here is a workaround for buggy behavior in `pip install` where pip would ignore the --prefix setting when --global-option was supplied. As it turns out, --global-option is deprecated anyway so we removed in Legion. As a result, this is no longer required; the prefix is already set in the upstream project and the need for --root goes away with the removal of --global-option. See this Legion MR for details: https://gitlab.com/StanfordLegion/legion/-/merge_requests/1072 * Make sure to use the latest Legion --------- Co-authored-by: Manolis Papadakis <[email protected]> Co-authored-by: Manolis Papadakis <[email protected]>
manopapad
added
the
category:improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing #932 to fix CI issues without affecting the main branch